Skip to content

remove unstable runtime setting from call_runtime example docs #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agryaznov merged 1 commit into from
Jun 2, 2023
Merged

remove unstable runtime setting from call_runtime example docs #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion call-runtime/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ To integrate this example into Substrate you need to adjust pallet contracts con
…
// `Everything` or anything that will allow for the `Balances::transfer` extrinsic.
type CallFilter = frame_support::traits::Everything;
type UnsafeUnstableInterface = ConstBool<true>;
Copy link
Contributor

@pgherveou pgherveou May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep it and specify for version of pallet-contract < xxx

Copy link
Contributor Author

@agryaznov agryaznov May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, it's just an example of a runtime configuration, imo it should just work with current master
we don't want to keep these nuances for each stabilized host function, right?

Copy link
Contributor

@pgherveou pgherveou May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mm I am pretty sure that a lot of people will run this against the contract-node that is only updated at every release

Copy link
Contributor Author

@agryaznov agryaznov May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it yesterday

…
}
```
Expand Down