fix(lint): false negative on CheckedBinaryOp

linting/src/strict_balance_equality.rs

@@ -233,7 +233,8 @@ impl Visitor<'_> for TransferFunction<'_, '_> {
     fn visit_assign(&mut self, place: &Place, rvalue: &Rvalue, _: Location) {
         match rvalue {
             // Result of direct comparison with balance
-            Rvalue::BinaryOp(BinOp::Eq | BinOp::Ne, box (lhs, rhs)) => {
+            Rvalue::BinaryOp(_, box (lhs, rhs))
+            | Rvalue::CheckedBinaryOp(_, box (lhs, rhs)) => {
                 if tainted_with_balance(self.state, lhs).is_some()
                     || tainted_with_balance(self.state, rhs).is_some()
                 {
@@ -328,7 +329,9 @@ impl<'a> TransferFunction<'_, '_> {
                 cached_results
             } else {
                 // Insert an empty value first to handle recursive calls
-                let _ = self.fun_cache.insert(cache_key.clone(), BitSet::new_empty(0));
+                let _ = self
+                    .fun_cache
+                    .insert(cache_key.clone(), BitSet::new_empty(0));
                 let results = self
                     .analyze_function(fn_def_id)
                     .unwrap_or(BitSet::new_empty(0));

linting/ui/fail/strict_balance_equality.rs

@@ -23,7 +23,7 @@ pub mod strict_balance_equality {
         }
         fn get_balance_3(&self) -> Balance {
             let tmp = self.env().balance();
-            tmp + 1
+            tmp + 42
         }
         fn get_balance_recursive(&self, acc: &Balance) -> Balance {
             if acc < &10_u128 {
@@ -33,9 +33,9 @@ pub mod strict_balance_equality {
             }
         }
 
-        fn cmp_balance(&self, value: &Balance) -> bool {
-            *value == self.env().balance()
-        }
+        // fn cmp_balance(&self, value: &Balance) -> bool {
+        //     *value == self.env().balance()
+        // }
 
         #[ink(message)]
         pub fn do_nothing(&mut self) {
@@ -50,11 +50,11 @@ pub mod strict_balance_equality {
             // Bad: Strict equality in function call: return value
             if self.get_balance_1() == 10 { /* ... */ }
             if self.get_balance_2() == 10 { /* ... */ }
-            //if self.get_balance_3() == 10 { /* ... */ } // TODO: false negative
+            if self.get_balance_3() == 10 { /* ... */ }
             if self.get_balance_recursive(&10) == 10 { /* ... */ }
 
             // Bad: Strict equality in function: tainted arguments
-            //if self.cmp_balance(&10) {}
+            // if self.cmp_balance(&10) {}
             // if self.check_balance(&self.env().balance(), &threshold) {
             //     // Do nothing
             // }

linting/ui/fail/strict_balance_equality.stderr

@@ -1,34 +1,46 @@
 error: dangerous strict balance equality
-  --> $DIR/strict_balance_equality.rs:39:37
+  --> $DIR/strict_balance_equality.rs:46:37
    |
 LL |             if self.env().balance() == 10 { /* ... */ }
    |                                     ^^ help: consider using non-strict equality operators instead: `<`, `>`
    |
    = note: `-D strict-balance-equality` implied by `-D warnings`
 
 error: dangerous strict balance equality
-  --> $DIR/strict_balance_equality.rs:40:22
+  --> $DIR/strict_balance_equality.rs:47:22
    |
 LL |             if value == 11 { /* ... */ }
    |                      ^^ help: consider using non-strict equality operators instead: `<`, `>`
 
 error: dangerous strict balance equality
-  --> $DIR/strict_balance_equality.rs:41:37
+  --> $DIR/strict_balance_equality.rs:48:37
    |
 LL |             if self.env().balance() == threshold { /* ... */ }
    |                                     ^^ help: consider using non-strict equality operators instead: `<`, `>`
 
 error: dangerous strict balance equality
-  --> $DIR/strict_balance_equality.rs:44:37
+  --> $DIR/strict_balance_equality.rs:51:37
    |
 LL |             if self.get_balance_1() == 10 { /* ... */ }
    |                                     ^^ help: consider using non-strict equality operators instead: `<`, `>`
 
 error: dangerous strict balance equality
-  --> $DIR/strict_balance_equality.rs:45:37
+  --> $DIR/strict_balance_equality.rs:52:37
    |
 LL |             if self.get_balance_2() == 10 { /* ... */ }
    |                                     ^^ help: consider using non-strict equality operators instead: `<`, `>`
 
-error: aborting due to 5 previous errors
+error: dangerous strict balance equality
+  --> $DIR/strict_balance_equality.rs:53:37
+   |
+LL |             if self.get_balance_3() == 10 { /* ... */ }
+   |                                     ^^ help: consider using non-strict equality operators instead: `<`, `>`
+
+error: dangerous strict balance equality
+  --> $DIR/strict_balance_equality.rs:54:48
+   |
+LL |             if self.get_balance_recursive(&10) == 10 { /* ... */ }
+   |                                                ^^ help: consider using non-strict equality operators instead: `<`, `>`
+
+error: aborting due to 7 previous errors