Skip to content

Linter: Warn about strict balance equality #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmichi merged 24 commits into from
Oct 25, 2023
Merged

Linter: Warn about strict balance equality #1914

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c00652c
feat(linter): strict balance equality lint
jubnzv Sep 5, 2023
422eff5
feat(lint): Handle temporary values resulted after Rvalue::Use
jubnzv Sep 8, 2023
c0c2b80
fix(lint): spans to emit diagnostics
jubnzv Sep 11, 2023
4de5d35
feat(tests): more tests
jubnzv Sep 11, 2023
e679c6f
feat(lint): Manually traverse functions in user-defined code
jubnzv Sep 12, 2023
0d2953f
feat(lint): interprocedural analysis that finds tainted returns
jubnzv Sep 13, 2023
20c34c5
fix(lint): recursive calls in interprocedural analysis
jubnzv Sep 13, 2023
233ddfa
fix(lint): false negative on `CheckedBinaryOp`
jubnzv Sep 13, 2023
1cfe0e4
feat(lint): propagation through references
jubnzv Sep 14, 2023
6512927
feat(lint): Propagate tainted values through `&mut` arguments
jubnzv Sep 15, 2023
7725462
chore(lint): docstring, comments
jubnzv Sep 15, 2023
c8434d4
feat(lint): handle comparison of references in functions
jubnzv Sep 15, 2023
62a5a35
chore(tests): comments
jubnzv Sep 15, 2023
0f99906
feat(lint+tests): updated `pass` test, fixed binop conditions
jubnzv Sep 15, 2023
3e8bde3
feat(tests): test for lint suppressions
jubnzv Sep 15, 2023
0e7bfee
Merge remote-tracking branch 'origin/master' into 1811-balance-condition
jubnzv Sep 15, 2023
46238bb
chore(tests): fmt
jubnzv Sep 15, 2023
0be39dd
chore(tests): fmt
jubnzv Sep 15, 2023
e202891
chore: Add changelog entry
jubnzv Sep 17, 2023
fc4a143
Merge remote-tracking branch 'origin/master' into 1811-balance-condition
jubnzv Oct 5, 2023
96d84e0
chore(lint): Reuse utility functions introduced in #1932
jubnzv Oct 5, 2023
5b5054a
chore: Fix changelog
jubnzv Oct 5, 2023
09f8f9b
Merge remote-tracking branch 'origin/master' into 1811-balance-condition
jubnzv Oct 25, 2023
fd358b8
chore: Fix comments
jubnzv Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Add changelog entry
  • Loading branch information
@jubnzv
jubnzv committed Sep 17, 2023
commit e202891f3d6b00f856c124502cd25cbd9abdfbae
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## Changed
### Changed
- Make `set_code_hash` generic - [#1906](https://github.com/paritytech/ink/pull/1906)

### Added
- Linter: `strict_balance_equality` lint - [#1914](https://github.com/paritytech/ink/pull/1914)

## Version 5.0.0-alpha

The preview release of the ink! 5.0.0 release.
Expand Down