Skip to content

Conversation

@VarnikaB
Copy link

@VarnikaB VarnikaB commented Oct 20, 2022

Fixed the invalid IPv6 address format:

  • BC:e4d5:c:e7b9::%40i0nccymtl9cwfKo.5vaeXLSGRMe:EDh2qs5wkhnPws5xQKqafjfAMm6wGFCJ.bVFsZfb
  • 1dC:0DF8:62D:3AC::%KTatXocjaFVioS0RTNQl4mA.V151o0RSy.JIu-D-D8.d3171ZWsSJ7PK4YjkJCRN0F
    as invalid

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

"fixes #2039"

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (531dc7f) to head (36b555c).
Report is 145 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2083   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new IP addresses that are invalid to the tests

@rubiin rubiin added needs-tests 🧹 needs-update For PRs that need to be updated before landing labels Oct 22, 2022
@VarnikaB
Copy link
Author

I have added the test cases

@VarnikaB VarnikaB requested a review from WikiRik October 24, 2022 02:53
@VarnikaB
Copy link
Author

I have added the test cases could you please approve it soon.

@rubiin rubiin added 🧹 needs-update For PRs that need to be updated before landing ✅ LGTM and removed 🧹 needs-update For PRs that need to be updated before landing labels Mar 28, 2024
@profnandaa
Copy link
Member

Can fix the merge conflict, other than that, LGTM. Thanks for your contrib!

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 25, 2024
@WikiRik
Copy link
Member

WikiRik commented Mar 27, 2025

Closing this in favour of #2453

@WikiRik WikiRik closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ LGTM mc-to-land Just merge-conflict standing between the PR and landing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPv6 regex accepts invalid formats

5 participants