fix #2039 IPv6 regex accepts invalid formats #2453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Due to the merger of #2089 this PR also has merge conflicts. Can you resolve them? |
WikiRik
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks for rebasing! The isIP tests are now moved to https://github.com/validatorjs/validator.js/blob/master/test/validators/isIP.test.js
Can you add the new test cases there? And remove the empty line you've added to the main test file?
This was referenced Mar 27, 2025
WikiRik
approved these changes
Mar 28, 2025
rubiin
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the incorrect IPv6 address formats:
BC:e4d5:c:e7b9::%40i0nccymtl9cwfKo.5vaeXLSGRMe:EDh2qs5wkhnPws5xQKqafjfAMm6wGFCJ.bVFsZfb
1dC:0DF8:62D:3AC::%KTatXocjaFVioS0RTNQl4mA.V151o0RSy.JIu-D-D8.d3171ZWsSJ7PK4YjkJCRN0F
These addresses are now correctly identified as invalid.
Updated the IPv6 address validation regex to correctly handle and reject invalid IPv6 address formats. The previous regex allowed formats that were not compliant with IPv6 standards. This fix ensures that only valid IPv6 addresses are accepted.
The validation structure is based on the corrected regex from branch #2083, which had merge conflicts that were resolved for accurate validation. This reference ensures that the updated regex conforms to the expected IPv6 address format and resolves the issue with invalid formats.
Checklist