Skip to content

fix #2039 IPv6 regex accepts invalid formats #2453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 28, 2025
Merged

fix #2039 IPv6 regex accepts invalid formats #2453

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8476579
fix #2039
Sep 14, 2024
a417afc
Merge branch 'master' into issue_2039
ShreySinha02 Mar 27, 2025
68bf25d
remove line and add test to isIp.test.js
Mar 28, 2025
6b5ac7c
change isIp
Mar 28, 2025
14fa522
Merge branch 'master' into issue_2039
rubiin Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isIP.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const IPv6AddressRegExp = new RegExp('^(' +
`(?:${IPv6SegmentFormat}:){2}(?:(:${IPv6SegmentFormat}){0,3}:${IPv4AddressFormat}|(:${IPv6SegmentFormat}){1,5}|:)|` +
`(?:${IPv6SegmentFormat}:){1}(?:(:${IPv6SegmentFormat}){0,4}:${IPv4AddressFormat}|(:${IPv6SegmentFormat}){1,6}|:)|` +
`(?::((?::${IPv6SegmentFormat}){0,5}:${IPv4AddressFormat}|(?::${IPv6SegmentFormat}){1,7}|:))` +
')(%[0-9a-zA-Z-.:]{1,})?$');
')(%[0-9a-zA-Z.]{1,})?$');

export default function isIP(ipAddress, options = {}) {
assertString(ipAddress);
Expand Down
1 change: 1 addition & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,6 +1045,7 @@ describe('Validators', () => {
});
});


it('should validate isIPRange', () => {
test({
validator: 'isIPRange',
Expand Down
Loading