feat: allow TTL to be a duration in days, weeks, etc..#9345
feat: allow TTL to be a duration in days, weeks, etc..#9345iTrooz wants to merge 19 commits intovelero-io:mainfrom
Conversation
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
|
Is this really needed? |
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
I believe so, entering backup TTL in hours can be annoying/error prone. For example, I wanted to create a 30d backup TTL for my personal cluster, and "30d" is more readable than "720h" But this is clearly a quality-of-life addition, it doesn't allow new things |
Signed-off-by: iTrooz <hey@itrooz.fr>
Co-authored-by: Tiger Kaovilai <passawit.kaovilai@gmail.com> Signed-off-by: iTrooz <hey@itrooz.fr>
|
don't forget to regenerate crd :) |
Signed-off-by: iTrooz <hey@itrooz.fr>
|
Whoops, thank you |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9345 +/- ##
==========================================
+ Coverage 59.67% 59.91% +0.23%
==========================================
Files 383 384 +1
Lines 44079 34991 -9088
==========================================
- Hits 26306 20966 -5340
+ Misses 16223 12479 -3744
+ Partials 1550 1546 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kaovilai
left a comment
There was a problem hiding this comment.
some further doc or implementation changes I think are needed.
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
Signed-off-by: iTrooz <hey@itrooz.fr>
|
Hello ! Could someone else please review this PR ? |
Thank you for contributing to Velero!
Please add a summary of your change
This PR changes the type used to parse TTLs, allowing parsing types largers than hours. The most obvious benefit is to allow days, but I also added weeks, months, and years
Does your change fix a particular issue?
No
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.Notes
For now, this feature has the following limitations:
I would be glad to add these changes, if there is an interest for it