Skip to content

feat: allow TTL to be a duration in days, weeks, etc.. #9345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iTrooz wants to merge 19 commits into
base: main
Choose a base branch
from
+316 −11
Open

feat: allow TTL to be a duration in days, weeks, etc.. #9345

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e6c4481
feat: allow TTL to be a duration in days
iTrooz Oct 17, 2025
1c169b7
clean
iTrooz Oct 17, 2025
4ab1933
update doc
iTrooz Oct 17, 2025
e5b0a77
add changelog
iTrooz Oct 17, 2025
e6414e2
fix
iTrooz Oct 22, 2025
1dd35eb
handle nanoseconds, ..., milliseconds
iTrooz Oct 23, 2025
facb612
fix
iTrooz Oct 23, 2025
97cf8d7
update tests
iTrooz Oct 23, 2025
8241f0c
update doc
iTrooz Oct 23, 2025
9357aba
update CRDs
iTrooz Oct 24, 2025
759b1b5
Update pkg/apis/velero/v1/backup_types.go
iTrooz Oct 24, 2025
ee33caf
update CRDs
iTrooz Oct 24, 2025
c3d1119
explain days/months/years static durations
iTrooz Oct 25, 2025
f5a4cce
add fractional support
iTrooz Oct 25, 2025
4cac3c3
do not test all units
iTrooz Oct 25, 2025
a010487
set years suffix to y
iTrooz Oct 25, 2025
efde95d
make 1mo=31d and 1y=366d
iTrooz Oct 25, 2025
b1a63ce
test with a number > 32bits
iTrooz Oct 25, 2025
b3e0744
update doc to mention 1mo=31d and 1y=366d
iTrooz Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix 
Signed-off-by: iTrooz <hey@itrooz.fr>
  • Loading branch information
@iTrooz
iTrooz committed Oct 23, 2025
commit facb612be273cf7ed65f4eb93979ace978559ef9
2 changes: 1 addition & 1 deletion pkg/apis/velero/v1/backup_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ type BackupSpec struct {
// +nullable
SnapshotVolumes *bool `json:"snapshotVolumes,omitempty"`

// TTL is a string describing how long
// TTL is a time.Duration-compatible string describing how long
// the Backup should be retained for.
// +optional
TTL metav1.Duration `json:"ttl,omitempty"`
Expand Down