Skip to content

[ci] feat: add mergify#5150

Open
vermouth1992 wants to merge 7 commits intoverl-project:mainfrom
vermouth1992:chi/mergify
Open

[ci] feat: add mergify#5150
vermouth1992 wants to merge 7 commits intoverl-project:mainfrom
vermouth1992:chi/mergify

Conversation

@vermouth1992
Copy link
Collaborator

What does this PR do?

  • Automatically at author if precommit fails.

Checklist Before Starting

  • Search for similar PRs. Paste at least one query link here: ...
  • Format the PR title as [{modules}] {type}: {description} (This will be checked by the CI)
    • {modules} include fsdp, megatron, veomni, sglang, vllm, rollout, trainer, ci, training_utils, recipe, hardware, deployment, ray, worker, single_controller, misc, perf, model, algo, env, tool, ckpt, doc, data, cfg, reward
    • If this PR involves multiple modules, separate them with , like [megatron, fsdp, doc]
    • {type} is in feat, fix, refactor, chore, test
    • If this PR breaks any API (CLI arguments, config, function signature, etc.), add [BREAKING] to the beginning of the title.
    • Example: [BREAKING][fsdp, megatron] feat: dynamic batching

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

API and Usage Example

Demonstrate how the API changes if any, and provide usage example(s) if possible.

# Add code snippet or script demonstrating how to use this

Design & Code Changes

Demonstrate the high-level design if this PR is complex, and list the specific changes.

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

@vermouth1992
Copy link
Collaborator Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a Mergify rule to automatically comment on pull requests and add a label when the pre-commit check fails. My review identifies a potential point of failure in the new rule. The condition for triggering the rule is tied to a specific Python version, which makes it brittle. I've suggested using a regular expression to make the rule more robust against future changes in the CI environment. There are no other issues.

- name: comment-pre-commit-failure
description: Comment on PR when pre-commit check fails
conditions:
- check-failure=pre-commit / pre-commit (3.12)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The condition check-failure=pre-commit / pre-commit (3.12) is brittle because it is hardcoded to a specific Python version (3.12). If the Python version in the CI workflow is updated, this rule will silently stop working. To make this rule more robust and future-proof, it's better to use a regular expression that isn't tied to the specific version.

      - check-failure~=^pre-commit / pre-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant