Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds a Mergify rule to automatically comment on pull requests and add a label when the pre-commit check fails. My review identifies a potential point of failure in the new rule. The condition for triggering the rule is tied to a specific Python version, which makes it brittle. I've suggested using a regular expression to make the rule more robust against future changes in the CI environment. There are no other issues.
| - name: comment-pre-commit-failure | ||
| description: Comment on PR when pre-commit check fails | ||
| conditions: | ||
| - check-failure=pre-commit / pre-commit (3.12) |
There was a problem hiding this comment.
The condition check-failure=pre-commit / pre-commit (3.12) is brittle because it is hardcoded to a specific Python version (3.12). If the Python version in the CI workflow is updated, this rule will silently stop working. To make this rule more robust and future-proof, it's better to use a regular expression that isn't tied to the specific version.
- check-failure~=^pre-commit / pre-commit
What does this PR do?
Checklist Before Starting
[{modules}] {type}: {description}(This will be checked by the CI){modules}includefsdp,megatron,veomni,sglang,vllm,rollout,trainer,ci,training_utils,recipe,hardware,deployment,ray,worker,single_controller,misc,perf,model,algo,env,tool,ckpt,doc,data,cfg,reward,like[megatron, fsdp, doc]{type}is infeat,fix,refactor,chore,test[BREAKING]to the beginning of the title.[BREAKING][fsdp, megatron] feat: dynamic batchingTest
API and Usage Example
# Add code snippet or script demonstrating how to use thisDesign & Code Changes
Checklist Before Submitting
Important
Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.
pre-commit install && pre-commit run --all-files --show-diff-on-failure --color=alwaysci-requestchannel in theverlSlack workspace. (If not accessible, please try the Feishu group (飞书群).)recipesubmodule, please also update the reference to the submodule commit viagit submodule update --remoteorcd recipe && git pull origin main.