Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/mergify.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
pull_request_rules:
- name: comment-pre-commit-failure
description: Comment on PR when pre-commit check fails
conditions:
- check-failure=pre-commit / pre-commit (3.12)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The condition check-failure=pre-commit / pre-commit (3.12) is brittle because it is hardcoded to a specific Python version (3.12). If the Python version in the CI workflow is updated, this rule will silently stop working. To make this rule more robust and future-proof, it's better to use a regular expression that isn't tied to the specific version.

      - check-failure~=^pre-commit / pre-commit

- -closed
- -draft
actions:
comment:
message: |
Hi @{{author}}, the pre-commit checks have failed. Please run:

```bash
pip install pre-commit
pre-commit install
# for staged changes
pre-commit run
# for all files in the repo
pre-commit run --all-files
```

Then, commit the changes and push to your branch.

For future commits, `pre-commit` will run automatically on changed files before each commit.

label:
add:
- pre-commit-failed
2 changes: 2 additions & 0 deletions tests/checkpoint_engine/test_special_server_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ async def test_server_adapter(init_config):
resource_pool=rollout_pool, ray_cls_with_init=ray_cls_with_init, device_name=get_device_name()
)



# 2.2 create rollout replicas
rollout_replica_class = get_rollout_replica_class(rollout_config.name)
rollout_replicas = [
Expand Down
Loading