Skip to content

RSDK-11726 — Remove GetImage, Format from Go SDK/RDK #5351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

RSDK-11726 — Remove GetImage, Format from Go SDK/RDK #5351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c810033
Make ReadImage call GetImages under the hood
hexbabe Sep 30, 2025
0a7b57b
Select matching mimetype image if available
hexbabe Sep 30, 2025
6a384ea
Remove ctx with value
hexbabe Sep 30, 2025
7fff04a
Fix affected tests
hexbabe Oct 1, 2025
99515ab
Make lint
hexbabe Oct 1, 2025
52f5ed9
wip
hexbabe Oct 2, 2025
4ffab13
Remove GetImages streaming feature flag and make it the default; Upda…
hexbabe Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix affected tests
  • Loading branch information
@hexbabe
hexbabe committed Oct 1, 2025
commit 7fff04a2e8be2f2df79c8edd70eb8afe547d038c
72 changes: 68 additions & 4 deletions services/datamanager/builtin/builtin_sync_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,23 @@ func TestSyncEnabled(t *testing.T) {
mimeType string,
extra map[string]interface{},
) ([]byte, camera.ImageMetadata, error) {
return newImageBytesResp(ctx, imgPng, mimeType)
t.Fatalf("ImageFunc should not be called")
return nil, camera.ImageMetadata{}, nil
},
ImagesFunc: func(
ctx context.Context,
filterSourceNames []string,
extra map[string]interface{},
) ([]camera.NamedImage, resource.ResponseMetadata, error) {
imgBytes, metadata, err := newImageBytesResp(ctx, imgPng, "image/jpeg")
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
namedImg, err := camera.NamedImageFromBytes(imgBytes, "", metadata.MimeType)
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
return []camera.NamedImage{namedImg}, resource.ResponseMetadata{CapturedAt: time.Now()}, nil
},
},
})
Expand Down Expand Up @@ -372,7 +388,23 @@ func TestDataCaptureUploadIntegration(t *testing.T) {
mimeType string,
extra map[string]interface{},
) ([]byte, camera.ImageMetadata, error) {
return newImageBytesResp(ctx, imgPng, mimeType)
t.Fatalf("ImageFunc should not be called")
return nil, camera.ImageMetadata{}, nil
},
ImagesFunc: func(
ctx context.Context,
filterSourceNames []string,
extra map[string]interface{},
) ([]camera.NamedImage, resource.ResponseMetadata, error) {
imgBytes, metadata, err := newImageBytesResp(ctx, imgPng, "image/jpeg")
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
namedImg, err := camera.NamedImageFromBytes(imgBytes, "", metadata.MimeType)
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
return []camera.NamedImage{namedImg}, resource.ResponseMetadata{CapturedAt: time.Now()}, nil
},
},
})
Expand Down Expand Up @@ -841,7 +873,23 @@ func TestStreamingDCUpload(t *testing.T) {
mimeType string,
extra map[string]interface{},
) ([]byte, camera.ImageMetadata, error) {
return newImageBytesResp(ctx, imgPng, mimeType)
t.Fatalf("ImageFunc should not be called")
return nil, camera.ImageMetadata{}, nil
},
ImagesFunc: func(
ctx context.Context,
filterSourceNames []string,
extra map[string]interface{},
) ([]camera.NamedImage, resource.ResponseMetadata, error) {
imgBytes, metadata, err := newImageBytesResp(ctx, imgPng, "image/jpeg")
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
namedImg, err := camera.NamedImageFromBytes(imgBytes, "", metadata.MimeType)
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
return []camera.NamedImage{namedImg}, resource.ResponseMetadata{CapturedAt: time.Now()}, nil
},
},
})
Expand Down Expand Up @@ -1082,7 +1130,23 @@ func TestSyncConfigUpdateBehavior(t *testing.T) {
mimeType string,
extra map[string]interface{},
) ([]byte, camera.ImageMetadata, error) {
return newImageBytesResp(ctx, imgPng, mimeType)
t.Fatalf("ImageFunc should not be called")
return nil, camera.ImageMetadata{}, nil
},
ImagesFunc: func(
ctx context.Context,
filterSourceNames []string,
extra map[string]interface{},
) ([]camera.NamedImage, resource.ResponseMetadata, error) {
imgBytes, metadata, err := newImageBytesResp(ctx, imgPng, "image/jpeg")
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
namedImg, err := camera.NamedImageFromBytes(imgBytes, "", metadata.MimeType)
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
return []camera.NamedImage{namedImg}, resource.ResponseMetadata{CapturedAt: time.Now()}, nil
},
},
})
Expand Down
18 changes: 15 additions & 3 deletions services/datamanager/builtin/builtin_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,11 +474,23 @@ func TestSync(t *testing.T) {
mimeType string,
extra map[string]interface{},
) ([]byte, camera.ImageMetadata, error) {
outBytes, err := rimage.EncodeImage(ctx, imgPng, mimeType)
t.Fatalf("ImageFunc should not be called")
return nil, camera.ImageMetadata{}, nil
},
ImagesFunc: func(
ctx context.Context,
filterSourceNames []string,
extra map[string]interface{},
) ([]camera.NamedImage, resource.ResponseMetadata, error) {
outBytes, err := rimage.EncodeImage(ctx, imgPng, "image/jpeg")
if err != nil {
return nil, resource.ResponseMetadata{}, err
}
namedImg, err := camera.NamedImageFromBytes(outBytes, "", "image/jpeg")
if err != nil {
return nil, camera.ImageMetadata{}, err
return nil, resource.ResponseMetadata{}, err
}
return outBytes, camera.ImageMetadata{MimeType: mimeType}, nil
return []camera.NamedImage{namedImg}, resource.ResponseMetadata{CapturedAt: time.Now()}, nil
},
},
})
Expand Down
Loading