fix cloudbuild case in validateReloadableArchive #5400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaellee1019
requested review from
gmulz,
njooma,
purplenicole730 and
stuqdog
viambot
added
the
safe to test
stuqdog
approved these changes
Oct 22, 2025
10zingpd
pushed a commit
that referenced
this pull request
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced in one of the last hot reloading improvement PRs. In the case of a cloudbuild reload, we don't need to check that a tarball exists at the
build.pathlocation. Instead the binary will be located in the reload folder.Was discussed in a slack thread and also noticed by fleet in 20% work.
@purplenicole730 tested by building the CLI and testing against a production machine.