calculate bounding box center from dims#5476
Draft
DTCurrie wants to merge 1 commit intoviamrobotics:mainfrom
Draft
calculate bounding box center from dims#5476DTCurrie wants to merge 1 commit intoviamrobotics:mainfrom
DTCurrie wants to merge 1 commit intoviamrobotics:mainfrom
Conversation
viambot
added
the
safe to test
bhaney
reviewed
Nov 12, 2025
| // calculate the spatial average center of a given point cloud | ||
| n := float64(cloud.Size()) | ||
| mean := r3.Vector{meta.TotalX() / n, meta.TotalY() / n, meta.TotalZ() / n} | ||
| mean := r3.Vector{dims.X / 2, dims.Y / 2, dims.Z / 2} |
Member
There was a problem hiding this comment.
you shouldn't use dims, as that is an the absolute value of the distance between the max and min. What you are looking for is the point inbetween the max and min, which would be
center := r3.Vector{(meta.MaxX + meta.MinX)/2.0, (meta.MaxY + meta.MinY)/2.0, (meta.MaxZ + meta.MinZ)/2.0}
Member
There was a problem hiding this comment.
for example, if MaxX was -2, and MinX was -5,
dim/2 = 1.5 (half of the length of X)
center = -3.5 (the center point between -2 and -5)
Member
Author
There was a problem hiding this comment.
I just put this up for @micheal-parks to discuss with you, but happy to make that change if we think that's more accurate!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for discussion