Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove validation
  • Loading branch information
vpandiarajan20 committed Dec 4, 2025
commit 994b80e2cae73acbe28a595bf1d288d87d2e5094
12 changes: 5 additions & 7 deletions cli/ml_training.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ const (
)

var (
dockerVertexImageRegex = regexp.MustCompile(`^us-docker\.pkg\.dev/vertex-ai/training/[^:@\s]+(:[^@\s]+)?(@sha256:[A-Fa-f0-9]{64})?$`)
validArgumentKeyRegex = regexp.MustCompile(`^[a-zA-Z0-9_-]+$`)
validArgumentKeyRegex = regexp.MustCompile(`^[a-zA-Z0-9_-]+$`)
)

type mlSubmitCustomTrainingJobArgs struct {
Expand Down Expand Up @@ -722,7 +721,7 @@ func MLTrainingScriptTestLocalAction(c *cli.Context, args mlTrainingScriptTestLo
cmd.Stdout = c.App.Writer
cmd.Stderr = c.App.ErrWriter

printf(c.App.Writer, "WARNING: If this is your first time running training, "+
warningf(c.App.ErrWriter, "If this is your first time running training, "+
"it may take a few minutes to download the container image. "+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minutes is a little bit of an understatement :)

"This is normal and will not affect the training process.")

Expand Down Expand Up @@ -951,10 +950,9 @@ func getContainerImageURI(c *viamClient, version string) (string, error) {

container, ok := res.ContainerMap[version]
if !ok {
if dockerVertexImageRegex.MatchString(version) {
return version, nil
}
return "", errors.Errorf("container version %s not found. Supported versions: %s", version, strings.Join(containerKeyList, ", "))
warningf(c.c.App.ErrWriter, "Container version %s not found. Supported versions: %s. "+
"Attempting to use provided value as container URI: %s", version, strings.Join(containerKeyList, ", "), version)
return version, nil
}
return container.Uri, nil
}
Loading