RSDK-12623: Viam cli can work with trace files from viam-server #5552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
benjirewis
reviewed
Dec 4, 2025
Co-authored-by: Benjamin Rewis <[email protected]>
viambot
added
safe to test
viambot
removed
the
safe to test
viambot
added
the
safe to test
benjirewis
approved these changes
Dec 4, 2025
Member
benjirewis
left a comment
benjirewis
left a comment
There was a problem hiding this comment.
Pretty much LGTM % the remaining note about defaulting to the current directory for the destination file.
… default bufio.Scanner buffer max size
…c command style, add more output
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
Member
Author
Member
stuqdog
approved these changes
Dec 9, 2025
Member
stuqdog
left a comment
stuqdog
left a comment
There was a problem hiding this comment.
A minor request to use the createUsageText helper (no need to rerequest review), otherwise lgtm!
| Usage: "Print traces from a remote viam machine to the console", | ||
| Description: ` | ||
| In order to use the print-remote command, the machine must have a valid shell type service. | ||
| Organization and location are required flags if using name (rather than ID) for the part. |
Member
There was a problem hiding this comment.
Would be nice to use createUsageText helper here (and in the other new methods) to get consistent usage text formatting. Also because currently, the usage text on viam traces get-remote --help includes USAGE: viam traces get-remote [command options] [target], but it isn't clear from this text that part is in fact a required field.
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
tracescommand to the cli with various subcommands to display or import trace files produced by viam-server.