refactor VoxelHistogram function to subpackage#5771
Draft
abe-winter wants to merge 1 commit intoviamrobotics:mainfrom
Draft
refactor VoxelHistogram function to subpackage#5771abe-winter wants to merge 1 commit intoviamrobotics:mainfrom
VoxelHistogram function to subpackage#5771abe-winter wants to merge 1 commit intoviamrobotics:mainfrom
Conversation
Move VoxelHistogram to a standalone function in pointcloud/visualize subpackage to avoid pulling liberation fonts (4.2MB), gonum/plot, go-pdf/fpdf, and go-hep/hplot into binaries that import pointcloud but don't need visualization. CLI binary drops from 52MB to 45MB. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
viambot
added
the
safe to test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Largest contributor to binary size of CLI (and presumably modules), not needed outside of tests.
CLI binary size goes down from 59 -> 53mb.