Improve error message when webcam config constraints don't match#5824
Open
hexbabe wants to merge 2 commits intoviamrobotics:mainfrom
Open
Improve error message when webcam config constraints don't match#5824hexbabe wants to merge 2 commits intoviamrobotics:mainfrom
hexbabe wants to merge 2 commits intoviamrobotics:mainfrom
Conversation
Add actionable guidance to the error message when no driver matches the configured constraints, suggesting users try relaxing width/height or changing frame format.
viambot
added
the
safe to test
viambot
added
safe to test
| "failed to find a queryable driver that matches the config constraints. Devices tried: %s", | ||
| "failed to find a queryable driver that matches the config constraints. "+ | ||
| "You can try tweaking or relaxing the constraints, e.g. removing or changing the height/width, "+ | ||
| "frame format, etc. Devices tried: %s", |
Contributor
There was a problem hiding this comment.
Does the Devices tried list include devices the height/width available on those drivers?, of not, is there a way to find that out?, I agree this message is better than the previous one, but it can be hard for the user to blindly try different height/width, frame formats, etc until one works.
Member
There was a problem hiding this comment.
Should the log push users to the webcam discovery service here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the error message when a webcam's configured constraints (resolution, frame format) don't match any available driver. The old message just listed devices tried — the new one also suggests actionable fixes:
Manual Tests
N/A — error message change only
PR Process
1 reviewer