RSDK-13456: Fix debug log level toggling in viam-server#5833
Open
EvanDorsky wants to merge 2 commits intoviamrobotics:mainfrom
Open
RSDK-13456: Fix debug log level toggling in viam-server#5833EvanDorsky wants to merge 2 commits intoviamrobotics:mainfrom
EvanDorsky wants to merge 2 commits intoviamrobotics:mainfrom
Conversation
viambot
added
the
safe to test
Member
|
can you add a test for this? |
benjirewis
reviewed
Mar 12, 2026
| // they match the new global log level. | ||
| // TODO: confirm that this causes modules to be restarted with the new log level | ||
| func alignModuleLogLevels(config *Config) { | ||
| if globalLogger.actualGlobalLogger != nil && globalLogger.actualGlobalLogger.GetLevel() != logging.DEBUG && config.Debug { |
Member
There was a problem hiding this comment.
[q] Was the issue here that because of && config.Debug, we were only "aligning module log levels" when debug: true was added to the JSON config, but not when debug: true was removed or debug: false was added?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the logic in
alignModuleLogLevelsthat would essentially latch all modules at the debug logging level untilviam-serverwas restarted.This is still WIP since I need to do some more testing to make sure this change doesn't cause excessive module restarts or any other undesired behavior. And I need to update the comment that I've marked
TODObefore merging.