Skip to content

Update minZoom check to ignore zoomOffset and rounding #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −3
Open

Update minZoom check to ignore zoomOffset and rounding #9807

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
318ce86
Fix that minzoom calcs were using round or ceil instead of floor
rory-orennia Oct 3, 2025
271d1ac
Merge branch 'master' into minzoom-fix
rory-orennia Oct 9, 2025
079ad41
update getTileIndices logic
rory-orennia Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix that minzoom calcs were using round or ceil instead of floor
  • Loading branch information
@rory-orennia
rory-orennia committed Oct 3, 2025
commit 318ce8616c83d99458482e7c0bd531afe2a2081c
4 changes: 2 additions & 2 deletions modules/geo-layers/src/tileset-2d/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,8 @@ export function getTileIndices({
zoomOffset?: number;
}) {
let z = viewport.isGeospatial
? Math.round(viewport.zoom + Math.log2(TILE_SIZE / tileSize)) + zoomOffset
: Math.ceil(viewport.zoom) + zoomOffset;
? Math.floor(viewport.zoom + Math.log2(TILE_SIZE / tileSize)) + zoomOffset
: Math.floor(viewport.zoom) + zoomOffset;
if (typeof minZoom === 'number' && Number.isFinite(minZoom) && z < minZoom) {
if (!extent) {
return [];
Expand Down
Loading