Skip to content

Update minZoom check to ignore zoomOffset and rounding #9807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −3
Open

Update minZoom check to ignore zoomOffset and rounding #9807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
318ce86
Fix that minzoom calcs were using round or ceil instead of floor
rory-orennia Oct 3, 2025
271d1ac
Merge branch 'master' into minzoom-fix
rory-orennia Oct 9, 2025
079ad41
update getTileIndices logic
rory-orennia Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions modules/geo-layers/src/tileset-2d/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,16 @@ export function getTileIndices({
modelMatrixInverse?: Matrix4;
zoomOffset?: number;
}) {
// This round/ceil operation ensures that tiles are rendered in the same way as Google Maps, Map Libre, etc.
// eg. at viewport.zoom = 9.5, you should fetch tiles at z = 10, not z = 9.
let z = viewport.isGeospatial
? Math.round(viewport.zoom + Math.log2(TILE_SIZE / tileSize)) + zoomOffset
: Math.ceil(viewport.zoom) + zoomOffset;
if (typeof minZoom === 'number' && Number.isFinite(minZoom) && z < minZoom) {
? Math.round(viewport.zoom + Math.log2(TILE_SIZE / tileSize) + zoomOffset)
: Math.ceil(viewport.zoom + zoomOffset);

// This check doesn't round/ceil and doesn't use the offset. This ensures that tiles are not rendered if the
// viewport.zoom is less than minZoom. eg. at viewport.zoom = 9.5 with minZoom = 10 we should not fetch tiles
// at z = 10 until viewport.zoom is 10 or greater.
if (typeof minZoom === 'number' && Number.isFinite(minZoom) && viewport.zoom < minZoom) {
if (!extent) {
return [];
}
Expand Down
8 changes: 8 additions & 0 deletions test/modules/geo-layers/tileset-2d/utils.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,14 @@ const TEST_CASES = [
maxZoom: undefined,
output: []
},
{
title: 'ignore round and offset on minZoom check',
viewport: new WebMercatorViewport({longitude: -90, latitude: 45, zoom: 3.5}),
zoomOffset: 1,
minZoom: 4,
maxZoom: undefined,
output: []
},
{
title: 'over zoom',
viewport: new WebMercatorViewport({
Expand Down
Loading