Skip to content

perf(css): only run postcss when needed #19061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 6 commits into from
Jan 24, 2025
Merged

perf(css): only run postcss when needed #19061

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
643d152
perf: only run postcss when needed
sapphi-red Dec 24, 2024
4c777ac
chore: merge main
sapphi-red Dec 25, 2024
76e3da4
refactor: use `hasUrl`
sapphi-red Jan 7, 2025
f177476
refactor: check for parser
sapphi-red Jan 7, 2025
a1394bf
refactor: add type
sapphi-red Jan 7, 2025
d00ce43
chore: merge main
sapphi-red Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: check for parser
  • Loading branch information
@sapphi-red
sapphi-red committed Jan 7, 2025
commit f177476232968889391e1037b6c4fb7030eb1ccc
11 changes: 7 additions & 4 deletions packages/vite/src/node/plugins/css.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,7 +1434,11 @@ async function compileCSS(
)
}

if (lang !== 'sss' && !postcssPlugins.length) {
const postcssOptions = postcssConfig?.options ?? {}
const postcssParser =
lang === 'sss' ? loadSss(config.root) : postcssOptions.parser

if (!postcssPlugins.length && !postcssParser) {
return {
code,
map: preprocessorMap,
Expand All @@ -1446,12 +1450,11 @@ async function compileCSS(
try {
const source = removeDirectQuery(id)
const postcss = await importPostcss()
const postcssOptions = postcssConfig?.options ?? {}

// postcss is an unbundled dep and should be lazy imported
postcssResult = await postcss.default(postcssPlugins).process(code, {
...postcssOptions,
parser: lang === 'sss' ? loadSss(config.root) : postcssOptions.parser,
parser: postcssParser,
to: source,
from: source,
...(devSourcemap
Expand Down Expand Up @@ -2156,7 +2159,7 @@ function loadSassPackage(root: string): {
}

let cachedSss: any
function loadSss(root: string) {
function loadSss(root: string): PostCSS.Syntax {
if (cachedSss) return cachedSss

const sssPath = loadPreprocessorPath(PostCssDialectLang.sss, root)
Expand Down
Loading