bump golang to 1.23.10 #265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adarsh Saxena <[email protected]>
Collaborator
|
Edited description to include CVEs fixed:
|
kaovilai
approved these changes
Jul 1, 2025
sseago
approved these changes
Jul 1, 2025
blackpiglet
requested changes
Jul 2, 2025
Contributor
blackpiglet
left a comment
blackpiglet
left a comment
There was a problem hiding this comment.
Please hold on to merge this PR.
Main branch doesn't need to pin the Golang version.
Sorry, @theadarshsaxena. I totally forgot that.
Sorry again for the misleading.
Author
|
no problem, I appreciate your intent to help 🙇♂️ |
Collaborator
|
The go mod is already pinned, perhaps only keep go.mod change but delete the Dockerfile changes? |
Collaborator
|
I see https://github.com/vmware-tanzu/velero/pull/9059/files is removing the go.mod toolchain line, so perhaps yeah. just close PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating PR as per suggestion in comment -> #264 (comment) by @blackpiglet
This PR is not a hard requirement for now, merge it if required else we can close this later.
CVEs fixed by this Go upgrade: