Skip to content

Conversation

@iTrooz
Copy link

@iTrooz iTrooz commented Oct 9, 2025

Thank you for contributing to Velero!

Please add a summary of your change

This PR adds colors to logs in velero backup logs and velero restore logs.
New visual:
image

Does your change fix a particular issue?

No

Please indicate you've done the following:

@github-actions github-actions bot added Dependencies Pull requests that update a dependency file has-changelog labels Oct 9, 2025
@github-actions github-actions bot requested a review from sseago October 9, 2025 11:59
@iTrooz
Copy link
Author

iTrooz commented Oct 25, 2025

@kaovilai Would you mind reviewing this when you get time ? I'd like to get feedback on it, even if it's a flat-out refusal.
Not urgent, please take your time

@kaovilai
Copy link
Collaborator

For approval I'll have to check more carefully. Let's see what others say.

Signed-off-by: iTrooz <[email protected]>
@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

❌ Patch coverage is 6.25000% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.80%. Comparing base (99f12b8) to head (61a5416).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
pkg/cmd/util/output/logs_color.go 0.00% 52 Missing ⚠️
pkg/cmd/cli/restore/logs.go 0.00% 4 Missing ⚠️
pkg/cmd/velero/velero.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9317      +/-   ##
==========================================
+ Coverage   59.67%   59.80%   +0.13%     
==========================================
  Files         383      384       +1     
  Lines       44050    35007    -9043     
==========================================
- Hits        26286    20937    -5349     
+ Misses      16218    12525    -3693     
+ Partials     1546     1545       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
@iTrooz
Copy link
Author

iTrooz commented Dec 4, 2025

TODO for myself: colors should not be present in velero bundle logs. I should investigate that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file has-changelog has-unit-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants