-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add color to velero logs #9317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
…ing logic Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
|
@kaovilai Would you mind reviewing this when you get time ? I'd like to get feedback on it, even if it's a flat-out refusal. |
|
For approval I'll have to check more carefully. Let's see what others say. |
Signed-off-by: iTrooz <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9317 +/- ##
==========================================
+ Coverage 59.67% 59.80% +0.13%
==========================================
Files 383 384 +1
Lines 44050 35007 -9043
==========================================
- Hits 26286 20937 -5349
+ Misses 16218 12525 -3693
+ Partials 1546 1545 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
Signed-off-by: iTrooz <[email protected]>
|
TODO for myself: colors should not be present in velero bundle logs. I should investigate that |
Thank you for contributing to Velero!
Please add a summary of your change
This PR adds colors to logs in

velero backup logsandvelero restore logs.New visual:
Does your change fix a particular issue?
No
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main. (not useful IMO ?)