Skip to content

feat: add color to velero logs #9317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iTrooz wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: add color to velero logs #9317

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8f26b0a
feat: make log level colored in `velero backup logs`
iTrooz Oct 8, 2025
bb975b1
use logfmt for parsing logs
iTrooz Oct 9, 2025
6e56558
colorize level value as well + refactor
iTrooz Oct 9, 2025
f15192c
fix typo
iTrooz Oct 9, 2025
54c9625
If NoColor, do not parse logs
iTrooz Oct 9, 2025
0150f06
wait for all logs to be processed before exiting
iTrooz Oct 9, 2025
c9ebc42
handle logs processing error
iTrooz Oct 9, 2025
3114ee6
refactor into a different file + add helper function to avoid clutter…
iTrooz Oct 9, 2025
fa40bbb
implement for restore logs too
iTrooz Oct 9, 2025
4ca4827
add changelog entry
iTrooz Oct 9, 2025
6b1f384
go mod tidy
iTrooz Oct 9, 2025
eeaec82
quote value if necessary
iTrooz Oct 9, 2025
61a5416
update doc
iTrooz Oct 25, 2025
05f9f0f
add copyright
iTrooz Oct 26, 2025
5a42287
do not print extra space after lines
iTrooz Oct 26, 2025
972b28d
add comments
iTrooz Oct 26, 2025
2fb573e
add tests
iTrooz Oct 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
colorize level value as well + refactor 
Signed-off-by: iTrooz <[email protected]>
  • Loading branch information
@iTrooz
iTrooz committed Oct 9, 2025
commit 6e56558c5616eb8961317e154d6ee87d0dba7eca
13 changes: 11 additions & 2 deletions pkg/cmd/cli/backup/logs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,20 @@ func processAndPrintLogs(r io.Reader, w io.Writer) {

// Re-encode with color. We do not use logfmt Encoder because it does not support color
for _, field := range fields {
var key, value string
if lineColor == nil { // handle case where no color (log level) was found
fmt.Fprintf(w, "%s=%s ", field[0], field[1])
key = string(field[0])
value = string(field[1])
} else {
fmt.Fprintf(w, "%s=%s ", lineColor.Sprintf("%s", field[0]), field[1])
key = lineColor.Sprintf("%s", field[0])
if string(field[0]) == "level" {
colorCopy := *lineColor
value = colorCopy.Add(color.Bold).Sprintf("%s", field[1])
} else {
value = string(field[1])
}
}
fmt.Fprintf(w, "%s=%s ", key, value)
}
fmt.Fprintln(w)
}
Expand Down