Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
093a61f
updated menubar editor example
jongund Mar 18, 2020
e8ab44f
updated tests
jongund Mar 19, 2020
e0b4b82
fixed some bugs
jongund Mar 19, 2020
942c4b9
imporved high contrast styling
jongund Mar 19, 2020
29b598d
fixed css padding bug
jongund Mar 19, 2020
671098d
adjusted css padding for menubar menuitems
jongund Mar 19, 2020
3062abf
updated CSS for border styling
jongund Mar 19, 2020
98f7b8a
fixed issue with failing regression tests
jongund Mar 19, 2020
4c50fc3
added comment
jongund Mar 19, 2020
2fd3c48
updated accessibility documentation
jongund Mar 19, 2020
cd75045
update CSS and event handlers to improve focus and hover styling
jongund Mar 24, 2020
2912f2e
updated focus and hover styling
jongund Mar 25, 2020
fe3600a
restore master package files
jongund Mar 31, 2020
177ca15
updated tests to identify failing tests due to Issue 1358
jongund Mar 31, 2020
65f2ae9
fix spacebar test
smhigley Apr 1, 2020
bd64491
removed issue 1358 reference
jongund Apr 1, 2020
d96c9f7
updated focus styling
jongund Apr 3, 2020
58f5e20
Editorial revisions to accessibility features section for consistency…
mcking65 Apr 14, 2020
8b179e9
Add missing link to style-manager.js
mcking65 Apr 14, 2020
feb190f
Merge branch 'master' into issue1355-update-menubar-editor-js
mcking65 Apr 14, 2020
27e0afd
removed role value normalization
jongund Apr 14, 2020
f2c3e93
added 1 pixel border on menubar to support better high contrast rende…
jongund Apr 20, 2020
30109da
updated focus styling
jongund Apr 22, 2020
03a9073
made changes based on todays conference call
jongund Apr 28, 2020
29eeb88
made changes based on todays conference call
jongund Apr 29, 2020
136ef04
made changes based on todays conference call
jongund Apr 29, 2020
8d4f626
conversted PNG images to SVG
jongund Apr 29, 2020
8f8c886
improved code
jongund Apr 29, 2020
579c1cb
updated menubar editor example
jongund Apr 29, 2020
8385f8b
updated the separator color for color contrast
jongund Apr 29, 2020
5a41939
removed the href from span and updated docuemntation
jongund Apr 29, 2020
576f39e
updated regression test to include more awaits
jongund May 1, 2020
e8d551e
added a few more awaits
jongund May 2, 2020
18f0c66
fixed conflict in regression tests
jongund May 6, 2020
cc5c24f
updated menubar editor example
jongund Mar 18, 2020
7fc4ed1
updated tests
jongund Mar 19, 2020
f1a69c0
fixed some bugs
jongund Mar 19, 2020
6e55dc8
imporved high contrast styling
jongund Mar 19, 2020
4ced0c6
fixed css padding bug
jongund Mar 19, 2020
0359a98
adjusted css padding for menubar menuitems
jongund Mar 19, 2020
61c7afb
updated CSS for border styling
jongund Mar 19, 2020
dfeaca3
fixed issue with failing regression tests
jongund Mar 19, 2020
95b48cb
added comment
jongund Mar 19, 2020
a3efb17
updated accessibility documentation
jongund Mar 19, 2020
0188e87
update CSS and event handlers to improve focus and hover styling
jongund Mar 24, 2020
d2c5341
updated focus and hover styling
jongund Mar 25, 2020
01ef7f0
restore master package files
jongund Mar 31, 2020
bf5810f
updated tests to identify failing tests due to Issue 1358
jongund Mar 31, 2020
d666561
updated focus styling
jongund Apr 3, 2020
09096ac
Editorial revisions to accessibility features section for consistency…
mcking65 Apr 14, 2020
cedcee3
Add missing link to style-manager.js
mcking65 Apr 14, 2020
0b3a895
removed role value normalization
jongund Apr 14, 2020
8ca49e6
added 1 pixel border on menubar to support better high contrast rende…
jongund Apr 20, 2020
b1fe749
updated focus styling
jongund Apr 22, 2020
7461535
made changes based on todays conference call
jongund Apr 28, 2020
36cd4d3
made changes based on todays conference call
jongund Apr 29, 2020
04f7c5f
conversted PNG images to SVG
jongund Apr 29, 2020
56bda10
improved code
jongund Apr 29, 2020
875e89f
updated menubar editor example
jongund Apr 29, 2020
9da2331
updated the separator color for color contrast
jongund Apr 29, 2020
1eb06e6
removed the href from span and updated docuemntation
jongund Apr 29, 2020
b4e76ab
updated regression test to include more awaits
jongund May 1, 2020
e822e9f
added a few more awaits
jongund May 2, 2020
0739a06
merge post-rebase updates
smhigley May 6, 2020
78784fb
Merge branch 'master' into issue1355-update-menubar-editor-js
jongund May 18, 2020
c4b8669
added arrow affordance on pull down menu items for low vision support
jongund May 28, 2020
9844b39
merged updates to master
jongund Jul 6, 2020
b6f0045
added preloading of images
jongund Jul 7, 2020
39a7293
restored package files
jongund Jul 8, 2020
b222f2f
restored regression file
jongund Jul 8, 2020
1b0155c
removed unused regression test file
jongund Jul 8, 2020
5c1140d
restored regression file
jongund Jul 8, 2020
3ed3afa
Merge branch 'master' into issue1355-update-menubar-editor-js
jongund Jul 9, 2020
586e3fe
restored original menubar editor example
jongund Jul 9, 2020
fa4da0b
Merge branch 'master' into issue1355-update-menubar-editor-js
mcking65 Jul 13, 2020
b1498b9
Merge branch 'master' into issue1355-update-menubar-editor-js
mcking65 Jul 13, 2020
d3dd867
Fix spelling of comment
Jul 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed conflict in regression tests
  • Loading branch information
jongund committed May 6, 2020
commit 18f0c66bef7beb1a293fdcf45ab8b869d3d5b073
60 changes: 30 additions & 30 deletions test/tests/menubar_menubar-editor.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ ariaTest('Test aria-label on textarea', exampleFile, 'textarea-aria-label', asyn

ariaTest('Test for role="menubar" on ul', exampleFile, 'menubar-role', async (t) => {


const menubars = await t.context.queryElements(t, ex.menubarSelector);

t.is(
Expand All @@ -116,7 +116,7 @@ ariaTest('Test aria-label on menubar', exampleFile, 'menubar-aria-label', async

ariaTest('Test for role="menuitem" on li', exampleFile, 'menubar-menuitem-role', async (t) => {


const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);

t.is(
Expand All @@ -135,7 +135,7 @@ ariaTest('Test for role="menuitem" on li', exampleFile, 'menubar-menuitem-role',

ariaTest('Test roving tabindex', exampleFile, 'menubar-menuitem-tabindex', async (t) => {


// Wait for roving tabindex to be initialized by the javascript
await exampleInitialized(t);

Expand All @@ -145,13 +145,13 @@ ariaTest('Test roving tabindex', exampleFile, 'menubar-menuitem-tabindex', async
ariaTest('Test aria-haspopup set to true on menuitems',
exampleFile, 'menubar-menuitem-aria-haspopup', async (t) => {


await assertAttributeValues(t, ex.menubarMenuitemSelector, 'aria-haspopup', 'true');
});

ariaTest('"aria-expanded" attribute on menubar menuitem', exampleFile, 'menubar-menuitem-aria-expanded', async (t) => {


// Before interating with page, make sure aria-expanded is set to false
await assertAttributeValues(t, ex.menubarMenuitemSelector, 'aria-expanded', 'false');

Expand Down Expand Up @@ -200,7 +200,7 @@ ariaTest('"aria-expanded" attribute on menubar menuitem', exampleFile, 'menubar-

ariaTest('Test for role="menu" on ul', exampleFile, 'menu-role', async (t) => {


const submenus = await t.context.queryElements(t, ex.submenuSelector);

// Test elements with role="menu" exist
Expand All @@ -223,7 +223,7 @@ ariaTest('Test for role="menu" on ul', exampleFile, 'menu-role', async (t) => {
});

ariaTest('Test for aria-label on role="menu"', exampleFile, 'menu-aria-label', async (t) => {

const submenusSelectors = [
'#ex1 li:nth-of-type(1) [role="menu"]',
'#ex1 li:nth-of-type(2) [role="menu"]',
Expand All @@ -238,7 +238,7 @@ ariaTest('Test for aria-label on role="menu"', exampleFile, 'menu-aria-label', a

ariaTest('Test for submenu menuitems with accessible names', exampleFile, 'submenu-menuitem-role', async (t) => {


const menuitems = await t.context.queryElements(t, ex.submenuMenuitemSelector);

t.truthy(
Expand Down Expand Up @@ -272,7 +272,7 @@ ariaTest('Test tabindex="-1" for all submenu role="menuitem"s',

ariaTest('Test aria-disabled="false" for all submenu role="menuitem"s',
exampleFile, 'submenu-menuitem-aria-disabled', async (t) => {

// "aria-disable" should be set to false by default
await assertAttributeValues(t, ex.submenuMenuitemSelector, 'aria-disabled', 'false');

Expand Down Expand Up @@ -309,7 +309,7 @@ ariaTest('Test aria-disabled="false" for all submenu role="menuitem"s',
});

ariaTest('Test for role="menuitemcheckbox" on li', exampleFile, 'menuitemcheckbox-role', async (t) => {

const checkboxes = await t.context.queryElements(t, ex.menuitemcheckboxSelector);

t.truthy(
Expand Down Expand Up @@ -340,7 +340,7 @@ ariaTest('Test tabindex="-1" for role="menuitemcheckbox"', exampleFile, 'menuite

ariaTest('Test "aria-checked" attirbute on role="menuitemcheckbox"',
exampleFile, 'menuitemcheckbox-aria-checked', async (t) => {

const menus = await t.context.queryElements(t, ex.menubarMenuitemSelector);

// Reveal the menuitemcheckbox elements in the second dropdown
Expand All @@ -359,7 +359,7 @@ ariaTest('Test "aria-checked" attirbute on role="menuitemcheckbox"',
}

// Select both menuitems
const checkboxes = await t.context.session.findElements(By.css(ex.menuitemcheckboxSelector));
const checkboxes = await t.context.queryElements(t, ex.menuitemcheckboxSelector);
await checkboxes[0].sendKeys(Key.ENTER);
await menus[1].sendKeys(Key.ARROW_DOWN);
await checkboxes[1].sendKeys(Key.ENTER);
Expand Down Expand Up @@ -394,7 +394,7 @@ ariaTest('Test aria-label on group', exampleFile, 'group-aria-label', async (t)

ariaTest('Test role="menuitemradio" exists with accessible name',
exampleFile, 'menuitemradio-role', async (t) => {

const items = await t.context.queryElements(t, ex.menuitemradioSelector);

// Test that the elements exist
Expand Down Expand Up @@ -462,7 +462,7 @@ ariaTest('Text "aria-checked" appropriately set on role="menitemradio"',
// KEYS

ariaTest('Key ENTER open submenu', exampleFile, 'menubar-key-space-and-enter', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);
for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {
Expand All @@ -484,7 +484,7 @@ ariaTest('Key ENTER open submenu', exampleFile, 'menubar-key-space-and-enter', a
});

ariaTest('Key SPACE open submenu', exampleFile, 'menubar-key-space-and-enter', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);
for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {
Expand All @@ -508,7 +508,7 @@ ariaTest('Key SPACE open submenu', exampleFile, 'menubar-key-space-and-enter', a


ariaTest('Key ESCAPE closes menubar', exampleFile, 'menubar-key-escape', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);
for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {
Expand All @@ -529,7 +529,7 @@ ariaTest('Key ESCAPE closes menubar', exampleFile, 'menubar-key-escape', async (
ariaTest('Key ARROW_RIGHT moves focus to next menubar item',
exampleFile, 'menubar-key-right-arrow', async (t) => {


const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);

for (let menuIndex = 0; menuIndex < ex.numMenus + 1; menuIndex++) {
Expand All @@ -551,7 +551,7 @@ ariaTest('Key ARROW_RIGHT moves focus to next menubar item',
ariaTest('Key ARROW_RIGHT moves focus to next menubar item',
exampleFile, 'menubar-key-left-arrow', async (t) => {


const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);

// Send the ARROW_LEFT key to the first menuitem
Expand Down Expand Up @@ -580,7 +580,7 @@ ariaTest('Key ARROW_RIGHT moves focus to next menubar item',
ariaTest('Key ARROW_UP opens submenu, focus on last item',
exampleFile, 'menubar-key-up-arrow', async (t) => {


const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);
for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {
Expand All @@ -606,7 +606,7 @@ ariaTest('Key ARROW_UP opens submenu, focus on last item',

ariaTest('Key ARROW_DOWN opens submenu, focus on first item',
exampleFile, 'menubar-key-down-arrow', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);
for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {
Expand All @@ -629,7 +629,7 @@ ariaTest('Key ARROW_DOWN opens submenu, focus on first item',
});

ariaTest('Key HOME goes to first item in menubar', exampleFile, 'menubar-key-home', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {

Expand All @@ -650,7 +650,7 @@ ariaTest('Key HOME goes to first item in menubar', exampleFile, 'menubar-key-hom
});

ariaTest('Key END goes to last item in menubar', exampleFile, 'menubar-key-end', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {

Expand All @@ -673,7 +673,7 @@ ariaTest('Key END goes to last item in menubar', exampleFile, 'menubar-key-end',
ariaTest('Character sends to menubar changes focus in menubar',
exampleFile, 'menubar-key-character', async (t) => {


const charIndexTest = [
{ sendChar: 'f', sendIndex: 0, endIndex: 0 },
{ sendChar: 's', sendIndex: 0, endIndex: 1 },
Expand All @@ -699,7 +699,7 @@ ariaTest('Character sends to menubar changes focus in menubar',
});

ariaTest('ENTER in submenu selects item', exampleFile, 'submenu-enter', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);

Expand Down Expand Up @@ -755,7 +755,7 @@ ariaTest('ENTER in submenu selects item', exampleFile, 'submenu-enter', async (t
});

ariaTest('ESCAPE to submenu closes submenu', exampleFile, 'submenu-escape', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);

Expand Down Expand Up @@ -792,7 +792,7 @@ ariaTest('ESCAPE to submenu closes submenu', exampleFile, 'submenu-escape', asyn
ariaTest('ARROW_RIGHT to submenu closes submenu and opens next',
exampleFile, 'submenu-right-arrow', async (t) => {


const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);

Expand Down Expand Up @@ -835,7 +835,7 @@ ariaTest('ARROW_RIGHT to submenu closes submenu and opens next',
ariaTest('ARROW_RIGHT to submenu closes submenu and opens next',
exampleFile, 'submenu-left-arrow', async (t) => {


const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);
const submenus = await t.context.queryElements(t, ex.submenuSelector);

Expand Down Expand Up @@ -876,7 +876,7 @@ ariaTest('ARROW_RIGHT to submenu closes submenu and opens next',
});

ariaTest('ARROW_DOWN moves focus to next item', exampleFile, 'submenu-down-arrow', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);

for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {
Expand All @@ -903,7 +903,7 @@ ariaTest('ARROW_DOWN moves focus to next item', exampleFile, 'submenu-down-arrow
});

ariaTest('ARROW_DOWN moves focus to previous item', exampleFile, 'submenu-up-arrow', async (t) => {

const menuitems = await t.context.queryElements(t, ex.menubarMenuitemSelector);

for (let menuIndex = 0; menuIndex < ex.numMenus; menuIndex++) {
Expand Down Expand Up @@ -988,7 +988,7 @@ ariaTest('END moves focus to last item', exampleFile, 'submenu-end', async (t) =
ariaTest('Character sends to menubar changes focus in menubar',
exampleFile, 'submenu-character', async (t) => {


const charIndexTest = [
[ // Tests for menu dropdown 0
{ sendChar: 's', sendIndex: 0, endIndex: 1 },
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.