Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
093a61f
updated menubar editor example
jongund Mar 18, 2020
e8ab44f
updated tests
jongund Mar 19, 2020
e0b4b82
fixed some bugs
jongund Mar 19, 2020
942c4b9
imporved high contrast styling
jongund Mar 19, 2020
29b598d
fixed css padding bug
jongund Mar 19, 2020
671098d
adjusted css padding for menubar menuitems
jongund Mar 19, 2020
3062abf
updated CSS for border styling
jongund Mar 19, 2020
98f7b8a
fixed issue with failing regression tests
jongund Mar 19, 2020
4c50fc3
added comment
jongund Mar 19, 2020
2fd3c48
updated accessibility documentation
jongund Mar 19, 2020
cd75045
update CSS and event handlers to improve focus and hover styling
jongund Mar 24, 2020
2912f2e
updated focus and hover styling
jongund Mar 25, 2020
fe3600a
restore master package files
jongund Mar 31, 2020
177ca15
updated tests to identify failing tests due to Issue 1358
jongund Mar 31, 2020
65f2ae9
fix spacebar test
smhigley Apr 1, 2020
bd64491
removed issue 1358 reference
jongund Apr 1, 2020
d96c9f7
updated focus styling
jongund Apr 3, 2020
58f5e20
Editorial revisions to accessibility features section for consistency…
mcking65 Apr 14, 2020
8b179e9
Add missing link to style-manager.js
mcking65 Apr 14, 2020
feb190f
Merge branch 'master' into issue1355-update-menubar-editor-js
mcking65 Apr 14, 2020
27e0afd
removed role value normalization
jongund Apr 14, 2020
f2c3e93
added 1 pixel border on menubar to support better high contrast rende…
jongund Apr 20, 2020
30109da
updated focus styling
jongund Apr 22, 2020
03a9073
made changes based on todays conference call
jongund Apr 28, 2020
29eeb88
made changes based on todays conference call
jongund Apr 29, 2020
136ef04
made changes based on todays conference call
jongund Apr 29, 2020
8d4f626
conversted PNG images to SVG
jongund Apr 29, 2020
8f8c886
improved code
jongund Apr 29, 2020
579c1cb
updated menubar editor example
jongund Apr 29, 2020
8385f8b
updated the separator color for color contrast
jongund Apr 29, 2020
5a41939
removed the href from span and updated docuemntation
jongund Apr 29, 2020
576f39e
updated regression test to include more awaits
jongund May 1, 2020
e8d551e
added a few more awaits
jongund May 2, 2020
18f0c66
fixed conflict in regression tests
jongund May 6, 2020
cc5c24f
updated menubar editor example
jongund Mar 18, 2020
7fc4ed1
updated tests
jongund Mar 19, 2020
f1a69c0
fixed some bugs
jongund Mar 19, 2020
6e55dc8
imporved high contrast styling
jongund Mar 19, 2020
4ced0c6
fixed css padding bug
jongund Mar 19, 2020
0359a98
adjusted css padding for menubar menuitems
jongund Mar 19, 2020
61c7afb
updated CSS for border styling
jongund Mar 19, 2020
dfeaca3
fixed issue with failing regression tests
jongund Mar 19, 2020
95b48cb
added comment
jongund Mar 19, 2020
a3efb17
updated accessibility documentation
jongund Mar 19, 2020
0188e87
update CSS and event handlers to improve focus and hover styling
jongund Mar 24, 2020
d2c5341
updated focus and hover styling
jongund Mar 25, 2020
01ef7f0
restore master package files
jongund Mar 31, 2020
bf5810f
updated tests to identify failing tests due to Issue 1358
jongund Mar 31, 2020
d666561
updated focus styling
jongund Apr 3, 2020
09096ac
Editorial revisions to accessibility features section for consistency…
mcking65 Apr 14, 2020
cedcee3
Add missing link to style-manager.js
mcking65 Apr 14, 2020
0b3a895
removed role value normalization
jongund Apr 14, 2020
8ca49e6
added 1 pixel border on menubar to support better high contrast rende…
jongund Apr 20, 2020
b1fe749
updated focus styling
jongund Apr 22, 2020
7461535
made changes based on todays conference call
jongund Apr 28, 2020
36cd4d3
made changes based on todays conference call
jongund Apr 29, 2020
04f7c5f
conversted PNG images to SVG
jongund Apr 29, 2020
56bda10
improved code
jongund Apr 29, 2020
875e89f
updated menubar editor example
jongund Apr 29, 2020
9da2331
updated the separator color for color contrast
jongund Apr 29, 2020
1eb06e6
removed the href from span and updated docuemntation
jongund Apr 29, 2020
b4e76ab
updated regression test to include more awaits
jongund May 1, 2020
e822e9f
added a few more awaits
jongund May 2, 2020
0739a06
merge post-rebase updates
smhigley May 6, 2020
78784fb
Merge branch 'master' into issue1355-update-menubar-editor-js
jongund May 18, 2020
c4b8669
added arrow affordance on pull down menu items for low vision support
jongund May 28, 2020
9844b39
merged updates to master
jongund Jul 6, 2020
b6f0045
added preloading of images
jongund Jul 7, 2020
39a7293
restored package files
jongund Jul 8, 2020
b222f2f
restored regression file
jongund Jul 8, 2020
1b0155c
removed unused regression test file
jongund Jul 8, 2020
5c1140d
restored regression file
jongund Jul 8, 2020
3ed3afa
Merge branch 'master' into issue1355-update-menubar-editor-js
jongund Jul 9, 2020
586e3fe
restored original menubar editor example
jongund Jul 9, 2020
fa4da0b
Merge branch 'master' into issue1355-update-menubar-editor-js
mcking65 Jul 13, 2020
b1498b9
Merge branch 'master' into issue1355-update-menubar-editor-js
mcking65 Jul 13, 2020
d3dd867
Fix spelling of comment
Jul 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
made changes based on todays conference call
  • Loading branch information
jongund committed Apr 29, 2020
commit 29eeb88369d217700a99a74f47af44302e47671b
32 changes: 17 additions & 15 deletions examples/menubar/css/menubar-editor.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,22 @@

.text-styling {
margin: 0;
padding: 0;
width: 560px;
}

.text-styling textarea {
padding: 5px;
margin: 0;
border: 1px solid black;
height: 400px;
width: 548px;
font-size: medium;
font-family: sans-serif;
}

ul[role="menubar"] {
margin: 0;
margin-top: 0.5em;
margin-bottom: 0.5em;
padding: 2px;
font-size: 110%;
list-style: none;
Expand All @@ -24,11 +39,6 @@ ul[role="menubar"] > li {
left: 1px;
}

ul[role="menubar"] > li > [role="menuitem"]::after {
content: url('../images/down-arrow-brown.png');
padding-left: 0.25em;
}

ul[role="menubar"] ul[role="menu"] {
display: none;
position: absolute;
Expand Down Expand Up @@ -151,11 +161,3 @@ ul[role="menubar"] [role="menu"] [role="menuitemradio"][aria-checked='true']:foc
text-decoration: underline;
}

#textarea1 {
padding: 0.5em;
border: 1px solid black;
height: 400px;
width: 70%;
font-size: medium;
font-family: sans-serif;
}
143 changes: 72 additions & 71 deletions examples/menubar/menubar-editor.html
Original file line number Diff line number Diff line change
Expand Up @@ -43,82 +43,83 @@ <h1>Editor Menubar Example</h1>
<h2 id="ex1_label">Example</h2>
<div role="separator" id="ex1_start_sep" aria-labelledby="ex1_start_sep ex1_label" aria-label="Start of"></div>
<div id="ex1">
<ul id="menubar1" role="menubar" aria-label="Text Formatting">
<li role="none">
<a role="menuitem" aria-haspopup="true" aria-expanded="false" href="#">Font</a>
<ul role="menu" data-option="font-family" aria-label="Font" >
<li role="menuitemradio" aria-checked="true">Sans-serif</li>
<li role="menuitemradio" aria-checked="false">Serif</li>
<li role="menuitemradio" aria-checked="false">Monospace</li>
<li role="menuitemradio" aria-checked="false">Fantasy</li>
</ul>
</li>
<li role="none">
<a role="menuitem" aria-haspopup="true" aria-expanded="false" href="#">Style/Color</a>
<ul role="menu" aria-label="Style/Color">
<li role="none">
<ul role="group" data-option="font-style" aria-label="Font Style">
<li role="menuitemcheckbox" data-option="font-bold" aria-checked="false">Bold</li>
<li role="menuitemcheckbox" data-option="font-italic" aria-checked="false">Italic</li>
</ul>
</li>
<li role="separator"></li>
<li role="none">
<ul role="group" data-option="font-color" aria-label="Text Color">
<li role="menuitemradio" aria-checked="true">Black</li>
<li role="menuitemradio" aria-checked="false">Blue</li>
<li role="menuitemradio" aria-checked="false">Red</li>
<li role="menuitemradio" aria-checked="false">Green</li>
</ul>
<li role="separator"></li>
<li role="none">
<ul role="group" data-option="text-decoration" aria-label="Text Decoration">
<li role="menuitemradio" aria-checked="true">None</li>
<li role="menuitemradio" aria-checked="false">Overline</li>
<li role="menuitemradio" aria-checked="false">Line-through</li>
<li role="menuitemradio" aria-checked="false">Underline</li>
</ul>
</ul>
</li>
<div class="text-styling">
<ul id="menubar1" role="menubar" aria-label="Text Formatting">
<li role="none">
<span role="menuitem" aria-haspopup="true" aria-expanded="false" href="#">Font</span>
<ul role="menu" data-option="font-family" aria-label="Font" >
<li role="menuitemradio" aria-checked="true">Sans-serif</li>
<li role="menuitemradio" aria-checked="false">Serif</li>
<li role="menuitemradio" aria-checked="false">Monospace</li>
<li role="menuitemradio" aria-checked="false">Fantasy</li>
</ul>
</li>
<li role="none">
<span role="menuitem" aria-haspopup="true" aria-expanded="false" href="#">Style/Color</span>
<ul role="menu" aria-label="Style/Color">
<li role="none">
<ul role="group" data-option="font-style" aria-label="Font Style">
<li role="menuitemcheckbox" data-option="font-bold" aria-checked="false">Bold</li>
<li role="menuitemcheckbox" data-option="font-italic" aria-checked="false">Italic</li>
</ul>
</li>
<li role="separator"></li>
<li role="none">
<ul role="group" data-option="font-color" aria-label="Text Color">
<li role="menuitemradio" aria-checked="true">Black</li>
<li role="menuitemradio" aria-checked="false">Blue</li>
<li role="menuitemradio" aria-checked="false">Red</li>
<li role="menuitemradio" aria-checked="false">Green</li>
</ul>
<li role="separator"></li>
<li role="none">
<ul role="group" data-option="text-decoration" aria-label="Text Decoration">
<li role="menuitemradio" aria-checked="true">None</li>
<li role="menuitemradio" aria-checked="false">Overline</li>
<li role="menuitemradio" aria-checked="false">Line-through</li>
<li role="menuitemradio" aria-checked="false">Underline</li>
</ul>
</ul>
</li>

<li role="none">
<a role="menuitem" aria-haspopup="true" aria-expanded="false" href="#">Text Align</a>
<ul role="menu" data-option="text-align" aria-label="Text Align">
<li role="menuitemradio" aria-checked="true">Left</li>
<li role="menuitemradio" aria-checked="false">Center</li>
<li role="menuitemradio" aria-checked="false">Right</li>
<li role="menuitemradio" aria-checked="false">Justify</li>
</ul>
</li>
<li role="none">
<span role="menuitem" aria-haspopup="true" aria-expanded="false" href="#">Text Align</span>
<ul role="menu" data-option="text-align" aria-label="Text Align">
<li role="menuitemradio" aria-checked="true">Left</li>
<li role="menuitemradio" aria-checked="false">Center</li>
<li role="menuitemradio" aria-checked="false">Right</li>
<li role="menuitemradio" aria-checked="false">Justify</li>
</ul>
</li>

<li role="none">
<a role="menuitem" aria-haspopup="true" aria-expanded="false" href="#">Size</a>
<ul role="menu" aria-label="Size" >
<li role="menuitem" data-option="font-smaller" aria-disabled="false">Smaller</li>
<li role="menuitem" data-option="font-larger" aria-disabled="false">Larger</li>
<li role="separator"></li>
<li>
<ul role="group" data-option="font-size" aria-label="Font Sizes">
<li role="menuitemradio" aria-checked="false">X-Small</li>
<li role="menuitemradio" aria-checked="false">Small</li>
<li role="menuitemradio" aria-checked="true">Medium</li>
<li role="menuitemradio" aria-checked="false">Large</li>
<li role="menuitemradio" aria-checked="false">X-Large</li>
</ul>
</ul>
</li>
</ul>
<li role="none">
<span role="menuitem" aria-haspopup="true" aria-expanded="false" href="#">Size</span>
<ul role="menu" aria-label="Size" >
<li role="menuitem" data-option="font-smaller" aria-disabled="false">Smaller</li>
<li role="menuitem" data-option="font-larger" aria-disabled="false">Larger</li>
<li role="separator"></li>
<li>
<ul role="group" data-option="font-size" aria-label="Font Sizes">
<li role="menuitemradio" aria-checked="false">X-Small</li>
<li role="menuitemradio" aria-checked="false">Small</li>
<li role="menuitemradio" aria-checked="true">Medium</li>
<li role="menuitemradio" aria-checked="false">Large</li>
<li role="menuitemradio" aria-checked="false">X-Large</li>
</ul>
</ul>
</li>
</ul>
<textarea id="textarea1" rows="20"
style="font-size: medium; font-family: sans-serif" aria-label="Text Sample"
>
Four score and seven years ago our fathers brought forth on this continent a new nation, conceived in Liberty, and dedicated to the proposition that all men are created equal.

<label for="textarea1" class="hidden">Text Sample</label><br>
<textarea id="textarea1" rows="20" cols="80"
style="font-size: medium; font-family: sans-serif"
>
Four score and seven years ago our fathers brought forth on this continent a new nation, conceived in Liberty, and dedicated to the proposition that all men are created equal.
Now we are engaged in a great civil war, testing whether that nation, or any nation, so conceived and so dedicated, can long endure. We are met on a great battle-field of that war. We have come to dedicate a portion of that field, as a final resting place for those who here gave their lives that that nation might live. It is altogether fitting and proper that we should do this.

Now we are engaged in a great civil war, testing whether that nation, or any nation, so conceived and so dedicated, can long endure. We are met on a great battle-field of that war. We have come to dedicate a portion of that field, as a final resting place for those who here gave their lives that that nation might live. It is altogether fitting and proper that we should do this.
But, in a larger sense, we can not dedicate, we can not consecrate, we can not hallow, this ground. The brave men, living and dead, who struggled here, have consecrated it, far above our poor power to add or detract. The world will little note, nor long remember what we say here, but it can never forget what they did here. It is for us the living, rather, to be dedicated here to the unfinished work which they who fought here have thus far so nobly advanced. It is rather for us to be here dedicated to the great task remaining before us, that from these honored dead we take increased devotion to that cause for which they gave the last full measure of devotion, that we here highly resolve that these dead shall not have died in vain, that this nation, under God, shall have a new birth of freedom, and that government of the people, by the people, for the people, shall not perish from the earth.
</textarea>
</div>

But, in a larger sense, we can not dedicate, we can not consecrate, we can not hallow, this ground. The brave men, living and dead, who struggled here, have consecrated it, far above our poor power to add or detract. The world will little note, nor long remember what we say here, but it can never forget what they did here. It is for us the living, rather, to be dedicated here to the unfinished work which they who fought here have thus far so nobly advanced. It is rather for us to be here dedicated to the great task remaining before us, that from these honored dead we take increased devotion to that cause for which they gave the last full measure of devotion, that we here highly resolve that these dead shall not have died in vain, that this nation, under God, shall have a new birth of freedom, and that government of the people, by the people, for the people, shall not perish from the earth.
</textarea>
<p>
<a href="https://en.wikipedia.org/wiki/Gettysburg,_Pennsylvania">More information on
Gettysburg Address</a>
Expand Down