Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[submodule "_external/aria-practices"]
path = _external/aria-practices
url = https://github.com/w3c/aria-practices.git
branch = main
branch = read-this-first-at-source
Copy link
Contributor Author

@howard-e howard-e Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Revert to main and run git submodule sync && git submodule update --init --recursive before merging once the related APG PR is merged

[submodule "_external/data"]
path = _external/data
url = https://github.com/w3c/wai-website-data.git
4 changes: 4 additions & 0 deletions ARIA/apg/patterns/accordion/accordion-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/alert/alert-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/alertdialog/alertdialog-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/breadcrumb/breadcrumb-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/button/button-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -154,4 +154,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/carousel/carousel-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -233,4 +233,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/checkbox/checkbox-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/combobox/combobox-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -509,4 +509,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/dialog-modal/dialog-modal-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,4 +209,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/disclosure/disclosure-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

2 changes: 1 addition & 1 deletion ARIA/apg/patterns/feed/examples/feed.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ permalink: /ARIA/apg/patterns/feed/examples/feed/

sidebar: true

footer: " <div class='example-page-footer'> <p><a href='https://github.com/orgs/w3c/projects/136'>View issues related to this example</a></p> <p>Page last updated: 3 November 2024</p> </div> "
footer: " <div class='example-page-footer'> <p><a href='https://github.com/orgs/w3c/projects/136'>View issues related to this example</a></p> <p>Page last updated: 2 November 2024</p> </div> "

# Context here: https://github.com/w3c/wai-aria-practices/issues/31
type_of_guidance: APG
Expand Down
4 changes: 4 additions & 0 deletions ARIA/apg/patterns/feed/feed-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,4 +180,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/grid/grid-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -468,4 +468,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/landmarks/landmarks-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,4 +113,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/link/link-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,4 +98,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/listbox/listbox-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -316,4 +316,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/menu-button/menu-button-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,4 +118,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/menubar/menu-and-menubar-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -292,4 +292,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/meter/meter-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,4 +113,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

15 changes: 4 additions & 11 deletions ARIA/apg/patterns/patterns.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,6 @@ lang: en
<div>


<div class="read-this-first">
<div class="text">
<img src="../../../content-images/wai-aria-practices/images/read-this-first.svg" width="178" alt="Illustration of a brown-skinned woman with a slight smile gesturing towards the right with her hand">
<h2>Read This First</h2>
<p>
No ARIA is better than Bad ARIA. Before using any ARIA, <a href="../practices/read-me-first/" aria-label="Read this to understand why no ARIA is better than bad ARIA">read this to understand why</a>.
</p>
</div>
</div>



<section class="pattern-filter-section">
<h2>Filter Patterns</h2>
Expand Down Expand Up @@ -486,4 +475,8 @@ lang: en
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:true"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/radio/radio-group-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -181,4 +181,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/slider/slider-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/spinbutton/spinbutton-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,4 +150,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/switch/switch-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/table/table-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -140,4 +140,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/tabs/tabs-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,4 +187,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/toolbar/toolbar-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -168,4 +168,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/tooltip/tooltip-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

9 changes: 9 additions & 0 deletions ARIA/apg/patterns/treegrid/treegrid-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ lang: en
<script src="../../../../content-assets/wai-aria-practices/shared/js/highlight.pack.js"></script>
<script src="../../../../content-assets/wai-aria-practices/shared/js/app.js"></script>

<script
data-read-this-first="showImage:false"
src="../../../../content-assets/wai-aria-practices/shared/js/read-this-first.js"
></script>


<link
rel="stylesheet"
Expand Down Expand Up @@ -370,4 +375,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/treeview/treeview-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -327,4 +327,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

4 changes: 4 additions & 0 deletions ARIA/apg/patterns/windowsplitter/windowsplitter-pattern.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,4 +144,8 @@ if (enableSidebar) document.body.classList.add('has-sidebar');
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:false"
></script>

15 changes: 4 additions & 11 deletions ARIA/apg/practices/practices.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,6 @@ lang: en
<div>


<div class="read-this-first">
<div class="text">
<img src="../../../content-images/wai-aria-practices/images/read-this-first.svg" width="178" alt="Illustration of a brown-skinned woman with a slight smile gesturing towards the right with her hand">
<h2>Read This First</h2>
<p>
No ARIA is better than Bad ARIA. Before using any ARIA, <a href="read-me-first/" aria-label="Read this to understand why no ARIA is better than bad ARIA">read this to understand why</a>.
</p>
</div>
</div>



<ul class="tiles">
<li class="tile">
Expand Down Expand Up @@ -148,4 +137,8 @@ lang: en
src="{{ '/content-assets/wai-aria-practices/shared/js/skipto.js' | relative_url }}"
data-skipto="colorTheme:aria; displayOption:popup; containerElement:div"
></script>
<script
src="{{ '/content-assets/wai-aria-practices/shared/js/read-this-first.js' | relative_url }}"
data-read-this-first="showImage:true"
></script>

2 changes: 1 addition & 1 deletion _external/aria-practices
Submodule aria-practices updated 36 files
+1 −0 content/patterns/accordion/accordion-pattern.html
+1 −0 content/patterns/alert/alert-pattern.html
+1 −0 content/patterns/alertdialog/alertdialog-pattern.html
+1 −0 content/patterns/breadcrumb/breadcrumb-pattern.html
+1 −0 content/patterns/button/button-pattern.html
+1 −0 content/patterns/carousel/carousel-pattern.html
+1 −0 content/patterns/checkbox/checkbox-pattern.html
+1 −0 content/patterns/combobox/combobox-pattern.html
+1 −0 content/patterns/dialog-modal/dialog-modal-pattern.html
+1 −0 content/patterns/disclosure/disclosure-pattern.html
+1 −0 content/patterns/feed/feed-pattern.html
+1 −0 content/patterns/grid/grid-pattern.html
+1 −0 content/patterns/landmarks/landmarks-pattern.html
+1 −0 content/patterns/link/link-pattern.html
+1 −0 content/patterns/listbox/listbox-pattern.html
+1 −0 content/patterns/menu-button/menu-button-pattern.html
+1 −0 content/patterns/menubar/menu-and-menubar-pattern.html
+1 −0 content/patterns/meter/meter-pattern.html
+1 −0 content/patterns/patterns.html
+1 −0 content/patterns/radio/radio-group-pattern.html
+1 −0 content/patterns/slider-multithumb/slider-multithumb-pattern.html
+1 −0 content/patterns/slider/slider-pattern.html
+1 −0 content/patterns/spinbutton/spinbutton-pattern.html
+1 −0 content/patterns/switch/switch-pattern.html
+1 −0 content/patterns/table/table-pattern.html
+1 −0 content/patterns/tabs/tabs-pattern.html
+1 −0 content/patterns/toolbar/toolbar-pattern.html
+1 −0 content/patterns/tooltip/tooltip-pattern.html
+2 −0 content/patterns/treegrid/treegrid-pattern.html
+1 −0 content/patterns/treeview/treeview-pattern.html
+1 −0 content/patterns/windowsplitter/windowsplitter-pattern.html
+1 −0 content/practices/practices.html
+170 −0 content/shared/js/read-this-first.js
+665 −837 package-lock.json
+12 −12 package.json
+11 −10 scripts/coverage-report.js
2 changes: 1 addition & 1 deletion _external/data
Loading