Fix #1058 - Display all comments for an issue (not just 30)#1147
Conversation
|
r? @miketaylr |
| var _id = $(location.hash); | ||
| window.scrollTo(0, _id.offset().top); | ||
| } | ||
| (response[0].lastPageNumber > 1) ? this.getRemainingComments(++response[0].lastPageNumber) : ''; |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
@deepthivenkat please run (I'm assuming that since grunt failed, maybe you didn't run tests again locally either?) |
|
As for the commit messages, this changset is re-introducing the fix for #1058, so it should reflect that (not just the difference between the last PR and this one). |
…. Place checks for empty link header
dcd08cf to
2924854
Compare
…hub api /issues/<issue_number>/comments
|
I have modified the first commit message to represent all the changes made in the commit. r? @miketaylr |
|
When you add that comment, LGTM. |
|
@deepthivenkat ping me when you've pushed that comment and I can merge (and so GitHub will send me an email. ^_^) |
2924854 to
51748e4
Compare
…e changes, adding comments for test case.
|
Aw dang. @deepthivenkat next time be sure to run pep8 as well when touching python code, thanks! |
|
(my bad for not noticing during review) |


…n 30