Fixes #1609 - remove logic for validating problem type from description…#1633
Merged
Fixes #1609 - remove logic for validating problem type from description…#1633
Conversation
cch5ng
force-pushed
the
issues/1609/2
branch
2 times, most recently
from
8389ae7 to
8188593
Compare
… field interaction tests: #1609; remove test for problem type validation; add test for description validation tests: #1574; update test to assume just one error message results tests: #1609; try use window helpers as in url test; possible timing issue when using css selector and click to change focus style: #1609; linting fix
Contributor
Author
|
@miketaylr R? (update) I think the only functional difference here is that there isn't a really a trigger for the problem type radio buttons validation error message to display. (update 2) p.s. I've actually had in mind a different flow for the form's required fields validation. the gist:
I could do a quick prototype of the concept. then people could give comments on it. probably towards mid week. |
Member
oops. my fail filters are looking for "r? @miketaylr" -- sorry i missed this! |
Contributor
Author
|
@miketaylr oh, sorry. didn't realize that was case sensitive but I'll remember for the future. thanks! |
Member
|
Cool, thanks @cch5ng! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… field interaction
tests: #1609; remove test for problem type validation; add test for description validation