detect test files if tsx --test script is present
#1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The binary issue seems to be fixed. Is my solution correct? |
webpro
reviewed
May 17, 2025
Member
webpro
left a comment
webpro
left a comment
There was a problem hiding this comment.
Thanks Nick! Happy to merge, but I do have a remark.
| const resolveConfig: ResolveConfig<PackageJson> = localConfig => { | ||
| const scripts = localConfig.scripts; | ||
|
|
||
| const entries = [toDependency('tsx')]; |
Member
There was a problem hiding this comment.
This one should probably not be added here. If tsx is listed in package.json but not used anywhere we probably want it reported as unused.
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "name": "tsx", | |||
| "bin": "" | |||
Member
There was a problem hiding this comment.
What I typically do is add an empty index.js file with "bin": "./index.js".
Knip looks here for the tsx executable referenced in package.json#scripts and understands the tsx dependency is used.
commit: |
webpro
reviewed
May 19, 2025
| import type { Plugin } from '../../types/config.js'; | ||
| import type { PackageJson } from 'src/types/package-json.js'; | ||
| import { toEntry } from 'src/util/input.js'; | ||
| import { hasDependency } from 'src/util/plugin.js'; |
Member
|
Nice one! 🙏 |
Member
|
🚀 This pull request is included in v5.57.0. See Release 5.57.0 for release notes. Using Knip in a commercial project? Please consider becoming a sponsor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how the node plugin detects test files if
node --testis present.Documented here: https://tsx.is/node-enhancement#test-runner
Two issues:
toBinaryincorrectly. The tests are failing.isEnabledwasn't being used for the tsx plugin before.