Skip to content

detect test files if tsx --test script is present #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webpro merged 7 commits into from
May 19, 2025
Merged

detect test files if tsx --test script is present #1090

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8e70452
detect test files if tsx --test script is present
ItsNickBarry May 16, 2025
05ab171
set bin in tsx fixture package.json
ItsNickBarry May 16, 2025
aae489a
do not resolve tsx dependency
ItsNickBarry May 17, 2025
f6a2816
add tsx bin fixture
ItsNickBarry May 17, 2025
e4ba4d7
remove unused import
ItsNickBarry May 17, 2025
63d384d
use relative imports
ItsNickBarry May 19, 2025
3e65590
fix formatting
ItsNickBarry May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/knip/fixtures/plugins/tsx/node_modules/tsx/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/knip/src/plugins/tsx/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { PackageJson } from 'src/types/package-json.js';
import { toBinary, toDependency, toEntry } from 'src/util/input.js';
import { toDependency, toEntry } from 'src/util/input.js';
import { hasDependency } from 'src/util/plugin.js';
Copy link
Member

@webpro webpro May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use relative imports

Copy link
Contributor Author

@ItsNickBarry ItsNickBarry May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

import type { IsPluginEnabled, Plugin, ResolveConfig } from '../../types/config.js';

Expand All @@ -18,7 +18,7 @@ const packageJsonPath = (id: PackageJson) => id;
const resolveConfig: ResolveConfig<PackageJson> = localConfig => {
const scripts = localConfig.scripts;

const entries = [toBinary('tsx'), toDependency('tsx')];
const entries = [toDependency('tsx')];
Copy link
Member

@webpro webpro May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should probably not be added here. If tsx is listed in package.json but not used anywhere we probably want it reported as unused.

Copy link
Contributor Author

@ItsNickBarry ItsNickBarry May 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


if (scripts && Object.keys(scripts).some(script => /(?<=^|\s)tsx\s(.*)--test/.test(scripts[script]))) {
const patterns = [
Expand Down