dtls: refactor cipher suite error handling with ok_or() #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cppcoffee
changed the title
Contributor
Author
|
hi @rainliu , can you review this PR? |
Replace verbose if-let-else patterns with concise ok_or() calls for better code readability and consistency across all cipher suite implementations. Changes: - CipherSuiteAes128Ccm: simplify encrypt/decrypt methods - CipherSuiteAes128GcmSha256: simplify encrypt/decrypt methods - CipherSuiteAes256CbcSha: simplify encrypt/decrypt methods - CipherSuiteChaCha20Poly1305Sha256: simplify encrypt/decrypt methods - CipherSuiteTlsPskWithAes128GcmSha256: simplify encrypt/decrypt methods Signed-off-by: Xiaobo Liu <[email protected]>
rainliu
approved these changes
Jun 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace verbose if-let-else patterns with concise ok_or() calls
for better code readability and consistency across all cipher
suite implementations.
Changes: