refactor: manifest as virtual module #14298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
ematipico
force-pushed
the
env-api/vite-plugin-routes
branch
from
fdc3bab to
f4db70b
Compare
ematipico
changed the title
ematipico
force-pushed
the
env-api/vite-plugin-routes
branch
from
9b7cb7d to
f0a6635
Compare
ascorbic
approved these changes
Sep 1, 2025
Contributor
ascorbic
left a comment
ascorbic
left a comment
There was a problem hiding this comment.
Looks like a good approach
packages/astro/test/units/vite-plugin-astro-server/request.test.js
Outdated
Show resolved
Hide resolved
ematipico
force-pushed
the
env-api/vite-plugin-routes
branch
from
2f18cc3 to
2868ab2
Compare
ascorbic
reviewed
Sep 2, 2025
github-actions
bot
added
feat: markdown
ematipico
force-pushed
the
env-api/vite-plugin-routes
branch
from
f17f70c to
4c16b50
Compare
github-actions
bot
removed
pkg: svelte
Member
Author
|
I'll investigate later why the integration tests time out. I'll merge the PR for now |
ematipico
added a commit
that referenced
this pull request
Sep 3, 2025
ematipico
added a commit
that referenced
this pull request
Sep 3, 2025
* refactor: use environments to load modules (#14191) * refactor: make `App` more extensible using `BaseApp` (#14197) * refactor: App to extends the new BaseApp (#14213) * refactor: manifest as virtual module (#14298) * refactor: create `generate` when needed * fix type * remove type * fix types * fix breakage of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR refactors how the manifest is computed and pulled during development and build.
There's a new module called
astro:serialized-manifest. While it returns a deserialised manifest, it's actually deserialised during its creation. It means that it's computed fromAstroSettings, and it's deserialised inside the virtual module.Happy to bikeshed the name.
Now
astro:config/serverandastro:config/clientuse this module to pull the information. Plus, I refactored them to usethis.environment.nameinstead ofopts.ssrTesting
Updated. They should all pass
Docs
N/A