refactor: create generate when needed #14303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
pkg: astro
ematipico
changed the title
ascorbic
reviewed
Sep 2, 2025
ematipico
force-pushed
the
env-api/route-list
branch
from
331ae31 to
c0b7c86
Compare
ematipico
force-pushed
the
feat/environment-api
branch
from
15a3eab to
c701fe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes
generatefromRouteData.generateis still present inIntegrationRouteDataThe reason why we want to remove this function from
RouteDatais because we plan to makeRouteData[]a virtual module, so downstream plugins can pull the data whenever they want.Testing
CI currently times out, however I made sure that locally no tests broke.
Docs
N/A