Vue: Remove hasDefaultExport check from appEntrypoint logic#9333
Merged
natemoo-re merged 6 commits intomainfrom Dec 6, 2023
Merged
Vue: Remove hasDefaultExport check from appEntrypoint logic#9333natemoo-re merged 6 commits intomainfrom
hasDefaultExport check from appEntrypoint logic#9333natemoo-re merged 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 6678e01 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: vue
1 task
matthewp
approved these changes
Dec 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
appEntrypointnot working #9330!hasDefaultExport, which is a Rollup API. This is available inastro buildbut not duringastro dev.astro devorastro buildTesting
Our previous test suite was missing
astro devtests, leading to incompatible behavior getting merged and released.This PR adds an
astro devtest while ensuring the previous tests are still passingDocs
Bug fix only