Conversation
🦋 Changeset detectedLatest commit: da8cfef The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: vue
|
Regarding #6827, we'll need to have access to imports to log a warning. Won't this be too hard with those changes? |
|
I don't think it'll be correct to access the imports that way to log a warning. The imports can go recursively too. I don't quite understand what's happening in #6827, but it seems like our CSS handling isn't working right when it's coming from integration client/server scripts. |
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
This seems much simpler, thanks for the PR!
| } | ||
| if (options?.appEntrypoint) { | ||
| const appEntrypoint = options.appEntrypoint.startsWith('.') | ||
| ? path.resolve(root, options.appEntrypoint) |
There was a problem hiding this comment.
root is a URL, does path.resolve automatically convert it to a file path?
There was a problem hiding this comment.
I'm currently retrieving the root from Vite's configResolved hook (which Astro passes), so it should already be a string path.
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Comments resolved, approved!
4 participants
Changes
Simplify
appEntrypointhandling. Followup from #8794 and #9333This change moves the default export check to runtime in dev. While this means we're unable to use the Astro logger, we can avoid the
this.resolve,this.load, andssrLoadModulecalls which can be expensive.With this PR, in dev we will log a warning if
defaultis not exported. In build, Rollup will log a warning instead thatdefaultis not exported.Testing
Existing tests should pass.
Docs
n/a. internal change.