-
-
Notifications
You must be signed in to change notification settings - Fork 834
Support multisite search on pagefind #2858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 97a4f6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
delucis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @XREvo! I’ve left a few comments.
One additional note: could you remove the changes to the non-English docs? In general we only change the English docs in implementation PRs and then allow our translators to update their individual languages to ensure they can fully update things correctly for their linguistic context.
Co-authored-by: Chris Swithinbank <[email protected]>
|
I've reverted my modification of translations with 10d9967 |
|
I let you resolve the conversations after review and i'm waiting for your feedback about the mergeFilter property. |
delucis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience on this one @XREvo! I think it looks good, and the mergeFilter schema seems correct to me.
I left a bunch of comments, but please don’t feel overwhelmed — they’re all tiny details to improve the documentation/comments 😁
I’m also happy to handle applying these if you prefer.
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
|
Thanks @delucis for this careful review |
delucis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR @XREvo! Will get this published as part of our next minor release 🙌
Co-authored-by: Chris Swithinbank <[email protected]>

Description
This had been tested locally with 2 instances :
What's next