Skip to content

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Feb 16, 2025

Description

This PR updates the French version of the reference/configuration page with the changes from #2858.

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2025

⚠️ No Changeset found

Latest commit: 069e9a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 16, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 16, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr reference/configuration.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link

netlify bot commented Feb 16, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 069e9a4
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67b22d563cd3cd0008f55a72
😎 Deploy Preview https://deploy-preview-2888--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I left some personal preference regarding linking to content that is not available in the same language, but that's not a "have to change" of course (like I said: personal pref)

What I find interesting is that the French version also didn't have the changes from #2728, but was marked as completed (same in German). Has to be unlucky timing with Lunaria udpates I guess...

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except an oversight.

@HiDeoo
Copy link
Member Author

HiDeoo commented Feb 16, 2025

Thanks for the reviews 🙌

@HiDeoo HiDeoo merged commit 932d4c0 into withastro:main Feb 16, 2025
15 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 19, 2025
* main: (493 commits)
  i18n(de): update `sidebar.mdx` (withastro#2900)
  Adding all samples for badges in sidebar as example (withastro#2881)
  i18n(fr): fix highlighting in `reference/plugins.md` (withastro#2898)
  i18n(fr): update `reference/plugins` & `guides/i18n` (withastro#2886)
  i18n(fr): update `reference/overrides` & `guides/sidebar` (withastro#2887)
  i18n(fr): add `guides/route-data` and `reference/route-data` (withastro#2884)
  i18n(fr): update `guides/overriding-components` (withastro#2885)
  i18n(fr): update `reference/configuration` (withastro#2888)
  i18n(de): update German translation with withastro#2578 (withastro#2882)
  [ci] format
  i18n(ru): update some translations (withastro#2895)
  i18n(de): update `reference/configuration.mdx` (withastro#2883)
  [ci] format
  i18n(ko-KR): update `configuration.mdx` (withastro#2892)
  i18n(ko-KR): update `overrides.md` (withastro#2893)
  i18n(ko-KR): update `overriding-components.mdx` (withastro#2890)
  i18n(ko-KR): update `i18n.mdx` and `plugins.md` (withastro#2889)
  [ci] format
  i18n(ko-KR): create `guides/route-data.mdx` and `reference/route-data.mdx` (withastro#2896)
  i18n(ko-KR): update `/resources/plugins.mdx` (withastro#2894)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants