Skip to content

Conversation

@trueberryless
Copy link
Contributor

Description

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 910d3fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Mar 25, 2025
@netlify
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 910d3fc
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67e2474384577a000802be69
😎 Deploy Preview https://deploy-preview-3016--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Mar 25, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de resources/themes.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@trueberryless
Copy link
Contributor Author

trueberryless commented Mar 25, 2025

Formating seems wrong, do you want me to add some autoformatting to Starlight PRs eg autofix which runs prettier?

@HiDeoo
Copy link
Member

HiDeoo commented Mar 25, 2025

Formating seems wrong, do you want me to add some autoformatting to Starlight PRs eg autofix which runs prettier?

We already have a workflow formatting the code except it's happening on the main branch so it'll automatically happen when the PR is merged so that branches (mostly) don't have to worry about formatting.

Altho, as you're doing frequent PRs and the repo is configured for it, I would make sure your IDE/text editor is properly configured to pick the repo configuration and use it, e.g. on save so everything you push is already formatted properly, or you manually run it with a shortcut, etc.

There is also the pnpm format command but it's more convenient when properly integrated with the IDE/text editor imo. If there is an issue with your IDE/text editor and the current configuration, let us know too, maybe it's something we can fix?

@trueberryless
Copy link
Contributor Author

Altho, as you're doing frequent PRs and the repo is configured for it, I would make sure your IDE/text editor is properly configured to pick the repo configuration and use it, e.g. on save so everything you push is already formatted properly, or you manually run it with a shortcut, etc.

I already have that set up on my PC, but my enthusiasm leads me to creating such PRs from my phone where not even a nice Android IDE is available... 🤣 That's the reason why some of my PRs look ugly...

But thanks for the answer, gonna let the formatting happen only on main!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we’ll let the robots worry about tabs vs spaces so we can use our brains for other things. Thanks for the update @trueberryless! 🫡

@delucis delucis merged commit dc25721 into withastro:main Mar 25, 2025
15 checks passed
@trueberryless trueberryless deleted the trueberryless-patch-3 branch March 25, 2025 16:43
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 4, 2025
* main: (43 commits)
  [ci] format
  i18n(ru): update some translations (withastro#3029)
  chore(deps): update zephyrproject-rtos/action-first-interaction digest to 5885399 (withastro#3027)
  [ci] release (withastro#3022)
  feat: add sourcehut as social option (withastro#3020)
  feat: Add Substack icon to social list (withastro#3013)
  [ci] format
  i18n(zh-cn): Update `overrides.md` and `overriding-components.mdx` (withastro#3006)
  [ci] format
  i18n(zh-cn): Update `i18n.mdx` and Update `plugins.md` (withastro#2940)
  i18n(ko-KR): update `ko.json` (withastro#3021)
  i18n(fr): update `resources/themes` (withastro#3019)
  [ci] format
  Update themes.mdx (withastro#3016)
  i18n(ko-KR): update `theme.mdx` (withastro#3015)
  Add starlight theme nova (withastro#3012)
  i18n(fr): update `reference/plugins.md` (withastro#3011)
  i18n(ko-KR): update `plugins.md` (withastro#3010)
  i18n(de): update `plugins.mdx` (withastro#3009)
  Fix code example in plugin reference (withastro#3005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants