Skip to content

feat: add sourcehut as social option #3020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2025
Merged

feat: add sourcehut as social option #3020

merged 4 commits into from
Mar 26, 2025

Conversation

@ayoayco
Copy link
Contributor

@ayoayco ayoayco commented Mar 25, 2025

Description

This PR will add SourceHut as an option in the social config. See discussion: #3008 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Mar 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: a461927

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 25, 2025
@netlify
Copy link

netlify bot commented Mar 25, 2025 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit a461927
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67e405681eba940008889370
😎 Deploy Preview https://deploy-preview-3020--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Mar 25, 2025

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@ayoayco ayoayco marked this pull request as draft March 25, 2025 20:35
@ayoayco ayoayco marked this pull request as ready for review March 26, 2025 06:24
delucis
delucis approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ayoayco! Will merge this as part of our next patch release. 🙌

I’ll admit this logo doesn’t seem very helpful for people less familiar with Sourcehut (not sure I’d understand that a circle in the site header indicates source code), but maybe once it’s more popular people will recognise it 😄

@ayoayco
Copy link
Contributor Author

ayoayco commented Mar 26, 2025

@delucis true! :) The platform is still public alpha, and I think they have not thought much about branding yet or want to go for a super minimal identity. I still think it is a good idea to add to StarLight, maybe it will help recognition. Thanks a lot for accepting!

@delucis
Copy link
Member

delucis commented Mar 26, 2025

Of course! Thank you for the PR 🙌

@delucis delucis added the 🌟 patch Change that triggers a patch release label Mar 26, 2025
@delucis delucis merged commit 58e3e84 into withastro:main Mar 26, 2025
15 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 26, 2025
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 4, 2025
@HiDeoo
Merge branch 'main' into hd-feat-iconify-icons
bf44ab5 
* main: (43 commits)
  [ci] format
  i18n(ru): update some translations (withastro#3029)
  chore(deps): update zephyrproject-rtos/action-first-interaction digest to 5885399 (withastro#3027)
  [ci] release (withastro#3022)
  feat: add sourcehut as social option (withastro#3020)
  feat: Add Substack icon to social list (withastro#3013)
  [ci] format
  i18n(zh-cn): Update `overrides.md` and `overriding-components.mdx` (withastro#3006)
  [ci] format
  i18n(zh-cn): Update `i18n.mdx` and Update `plugins.md` (withastro#2940)
  i18n(ko-KR): update `ko.json` (withastro#3021)
  i18n(fr): update `resources/themes` (withastro#3019)
  [ci] format
  Update themes.mdx (withastro#3016)
  i18n(ko-KR): update `theme.mdx` (withastro#3015)
  Add starlight theme nova (withastro#3012)
  i18n(fr): update `reference/plugins.md` (withastro#3011)
  i18n(ko-KR): update `plugins.md` (withastro#3010)
  i18n(de): update `plugins.mdx` (withastro#3009)
  Fix code example in plugin reference (withastro#3005)
  ...
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@ayoayco @delucis
feat: add sourcehut as social option (withastro#3020)
ca2d7f1 
Co-authored-by: Chris Swithinbank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ayoayco @astrobot-houston @delucis