-
-
Notifications
You must be signed in to change notification settings - Fork 832
docs: add <StarlightPage> import order guidelines
#3199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add <StarlightPage> import order guidelines
#3199
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Not sure if this needs a review by @sarah11918 ? |
Co-authored-by: Sarah Rainsberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fair to document this workaround for now. Hopefully we can fix this properly soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such PR, much wow!
See withastro#3199 + other edits based on the French Astro i18n guide
Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: astrobot-houston <[email protected]> Co-authored-by: alvinometric <[email protected]> Co-authored-by: sarah11918 <[email protected]> Co-authored-by: delucis <[email protected]> Co-authored-by: louisescher <[email protected]>

Description
This PR updates the
<StarlightPage>component documentation to help with issue 2 in #3162:After trying many possible workarounds to find a way around what seems to be an unsolvable issue, which depends on how import order works in Astro and also many variables e.g. the number of routes, etc., this PR adds guidelines to the documentation regarding the import order of the
<StarlightPage>component and its role in setting up cascade layers.This first attempt is based on recommendations from Sarah during a Talking & Doc'ing session mentioning the limitations using text and code example comments.
I tried to avoid an aside even tho we use one in the Astro Docs:
Considering how tricky this is, maybe it should be an aside but I wanted to try a first approach without it. Open to any suggestions.