Skip to content

Conversation

@HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented May 13, 2025

Description

This PR updates the <StarlightPage> component documentation to help with issue 2 in #3162:

After trying many possible workarounds to find a way around what seems to be an unsolvable issue, which depends on how import order works in Astro and also many variables e.g. the number of routes, etc., this PR adds guidelines to the documentation regarding the import order of the <StarlightPage> component and its role in setting up cascade layers.

This first attempt is based on recommendations from Sarah during a Talking & Doc'ing session mentioning the limitations using text and code example comments.

I tried to avoid an aside even tho we use one in the Astro Docs:

image

Considering how tricky this is, maybe it should be an aside but I wanted to try a first approach without it. Open to any suggestions.

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: 0943c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 13, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 0943c8c
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/685d5304e18d7500089be247
😎 Deploy Preview https://deploy-preview-3199--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 📚 docs Documentation website changes label May 13, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 13, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/pages.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@lrstanley lrstanley mentioned this pull request May 14, 2025
1 task
@alvinometric
Copy link
Contributor

Not sure if this needs a review by @sarah11918 ?

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair to document this workaround for now. Hopefully we can fix this properly soon!

Copy link
Member

@louisescher louisescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such PR, much wow!

@HiDeoo HiDeoo merged commit 7a891db into withastro:main Jun 26, 2025
15 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/starlight that referenced this pull request Jun 27, 2025
See withastro#3199 + other edits based on the French Astro i18n guide
frostybee pushed a commit to frostybee/starlight that referenced this pull request Jul 6, 2025
Co-authored-by: Sarah Rainsberger <[email protected]>

Co-authored-by: astrobot-houston <[email protected]>
Co-authored-by: alvinometric <[email protected]>
Co-authored-by: sarah11918 <[email protected]>
Co-authored-by: delucis <[email protected]>
Co-authored-by: louisescher <[email protected]>
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants