Skip to content

Conversation

@jsparkdev
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2025

⚠️ No Changeset found

Latest commit: ebb18f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 27, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit ebb18f6
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/685e966618c0d00008883476
😎 Deploy Preview https://deploy-preview-3257--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Jun 27, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 27, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ko guides/pages.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I reviewed this PR as a non-native speaker.

One thing we could also adapt, similar to how I adapted it in German are two newlines in line 103 (the <a> element), so that the formatter doesn't make it look kinda scuffed... (Unfortunately this is out of the review range, so I have to guide you with my words)

@jsparkdev
Copy link
Member Author

@trueberryless

Thank you! I updated it.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR!

L perfect TM 🎉

@jsparkdev jsparkdev merged commit cdd770a into withastro:main Jun 27, 2025
15 checks passed
@jsparkdev jsparkdev deleted the pages branch June 27, 2025 13:09
frostybee pushed a commit to frostybee/starlight that referenced this pull request Jul 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants