-
-
Notifications
You must be signed in to change notification settings - Fork 833
docs: add starlight-themes link #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
delucis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great addition and site! I’m being hyper fussy probably but left a suggestion.
One question: how will the demo site keep updated with the themes on this page? Is there a risk we add some themes here without them being added to the demo site?
Co-authored-by: Chris Swithinbank <[email protected]>
|
Great suggestion, as usual! Thanks.
The source is our showcase page. An issue is created or updated every day if a theme is missing. This has been great, as with the slightly unusual setup, I found a few theme bugs that I've been able to report back to the theme authors and have been fixed (which in the end benefit everyone). The currently only missing theme is in this case and the author is working on a fix. |
Ah, fantastic — you always think of everything 🔥 |
trueberryless
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks for this awesome addition to Starlight's themes, @HiDeoo !
* main: (47 commits) feat: add some of trueberryless' new Starlight blogs to community content (withastro#3525) i18n(fr): update `resources/themes` (withastro#3526) Fix file filters added in withastro#3520 (withastro#3522) i18n(fr): update `guides/site-search.mdx` (withastro#3524) i18n(fr): update `resources/plugins.mdx` (withastro#3523) docs: add starlight-themes link (withastro#3510) i18n(de): update translation resources/plugins.mdx (withastro#3519) i18n(de): update translation guides/site-search.mdx (withastro#3518) Skip a11y CI checks for docs changes that aren’t tested anyway (withastro#3520) Speed up Linux e2e tests (withastro#3517) i18n(ru): update translations (withastro#3512) Tweak a11y e2e tests (withastro#3507) [ci] format docs(plugin): starlight-docsearch-typesense (withastro#3504) Add starlight-page-actions (withastro#3515) ci: update file icons (withastro#3511) [i18nIgnore] Match title case convention for components/using-components (withastro#3508) Disable Prettier on GitHub Actions workflow files (withastro#3509) [ci] release (withastro#3490) Update release workflow for OIDC (withastro#3500) ...

Description
As discussed, this PR adds a link to the Starlight Themes website in the themes showcase as it provides an different way to explore all themes.
I tried to make it concise but happy to adjust the wording if needed.