Use plural method for multiple media selection handling #10857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
|
You can test the changes on this Pull Request by downloading the APK here. |
Generated by 🚫 dangerJS |
malinajirka
requested changes
Nov 27, 2019
Contributor
malinajirka
left a comment
malinajirka
left a comment
There was a problem hiding this comment.
Thanks @mkevins! I've left two minor comments. However, I believe we should do a small clean up before we merge this PR - most importantly remove the appendMediaFile since it's not being used anymore. Wdyt?
...ditor/WordPressEditor/src/main/java/org/wordpress/android/editor/EditorFragmentAbstract.java
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
Show resolved
Hide resolved
malinajirka
approved these changes
Nov 28, 2019
Contributor
malinajirka
left a comment
malinajirka
left a comment
There was a problem hiding this comment.
Thanks for the changes!! ;) LGTM - I'm approving this PR and marking it as ready for merge. I'm not sure how the process works when the PR relies on changes from gutenberg-mobile repo so I'll leave the merge to you @mkevins . 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to consolidate various media selection handling by refactoring methods that utilize both singular and plural paradigms to only use plural methods where possible.
We should preserve the behavior that occurs when multiple images are selected via the media library intent (multiple selection is possible for the image block even though the
allowMultipleSelectionflag is false).Related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1621
To test:
Image block:
When multiple items are selected via the media library in the image block, the additional items are appended to the editor as new image blocks.
Gallery block:
Related PR: #10703
Checkout related Gallery PR and build with source.
Expected behavior:
The selected images should be added to the gallery, and not added as new image blocks.
Update release notes:
I have considered adding unit tests where possible.
I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.