-
Notifications
You must be signed in to change notification settings - Fork 57
Use plural method for multiple media selection handling #1621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...nberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
Outdated
Show resolved
Hide resolved
...nberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
Show resolved
Hide resolved
...-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/Media.java
Outdated
Show resolved
Hide resolved
...nberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
Outdated
Show resolved
Hide resolved
...nberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
Outdated
Show resolved
Hide resolved
...nberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
Show resolved
Hide resolved
...nberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
Show resolved
Hide resolved
malinajirka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@malinajirka thanks for pairing / collaborating on this 👍 @dratwas 👋 thanks for reviewing. I've set the |
|
I had to make one additional change to make the enum - mimeType truncation work (the comparison / truncation should be all lowercase). |
This PR aims to consolidate various media selection handling by refactoring methods that utilize both singular and plural paradigms to only use plural methods where possible.
We should preserve the behavior that occurs when multiple images are selected via the media library intent (multiple selection is possible for the image block even though the
allowMultipleSelectionflag is false).Related WordPress-Android PR: wordpress-mobile/WordPress-Android#10857
To test:
Image block:
When multiple items are selected via the media library in the image block, the additional items are appended to the editor as new image blocks.
Gallery block:
Related PR: wordpress-mobile/WordPress-Android#10703
Checkout related Gallery PR and build with source.
Expected behavior:
The selected images should be added to the gallery, and not added as new image blocks.
Update release notes:
RELEASE-NOTES.txt.