Skip to content

Gutenberg: update to v1.18.0 #10863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxme merged 5 commits into from
Nov 29, 2019
Merged

Gutenberg: update to v1.18.0 #10863

maxme merged 5 commits into from
Nov 29, 2019

Conversation

@maxme
Copy link
Contributor

@maxme maxme commented Nov 27, 2019 •
edited
Loading

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1627

Changes:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@maxme maxme added the Gutenberg Editing and display of Gutenberg blocks. label Nov 27, 2019
@maxme maxme added this to the 13.8 milestone Nov 27, 2019
@maxme maxme mentioned this pull request Nov 27, 2019
Merged
@maxme maxme requested review from marecar3 and mchowning November 27, 2019 13:42
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 27, 2019 •
edited
Loading

You can test the changes on this Pull Request by downloading the APK here.

@maxme
Copy link
Contributor Author

maxme commented Nov 29, 2019

I tested new features (Spacer + range settings) but also image captions to make sure the iOS fix for caption alignment wasn't doing any side effect.

@maxme maxme requested a review from hypest November 29, 2019 14:29
cameronvoell
cameronvoell approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@cameronvoell cameronvoell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified RangeCell and Spacer Block updates, and they both look good. Smoke tests around editing an article and viewing image blocks etc all look good as well.

@hypest
Copy link
Contributor

hypest commented Nov 29, 2019

Tested and looks good:

✅ RangeCell styling refactor
✅ Enable Spacer block in production

@maxme maxme merged commit aed0c79 into develop Nov 29, 2019
@oguzkocer oguzkocer deleted the gutenberg/integrate_release_1.18.0 branch April 15, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marecar3 marecar3 Awaiting requested review from marecar3

@mchowning mchowning Awaiting requested review from mchowning

@hypest hypest Awaiting requested review from hypest

1 more reviewer

@cameronvoell cameronvoell cameronvoell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Milestone

13.8

Development

Successfully merging this pull request may close these issues.

4 participants

@maxme @hypest @cameronvoell