Skip to content

Conversation

@geriux
Copy link
Contributor

@geriux geriux commented Nov 19, 2019

This enables the Spacer block in production

Fixes #1587

Gutenberg PR -> WordPress/gutenberg#18605

To test:

WordPress iOS -> wordpress-mobile/WordPress-iOS#12970
WordPress Android -> wordpress-mobile/WordPress-Android#10817

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@geriux geriux marked this pull request as ready for review November 19, 2019 14:04
@geriux geriux requested a review from pinarol November 19, 2019 14:04
@geriux geriux added the Blocks label Nov 19, 2019
@geriux geriux added this to the 1.18 milestone Nov 19, 2019
@geriux geriux requested review from SergioEstevao and marecar3 and removed request for pinarol November 20, 2019 10:11
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on iOS! :shipit:

@marecar3
Copy link
Contributor

marecar3 commented Nov 26, 2019

Hey @geriux, not sure if I am missing some context but usually the practice is that we update bundle files through the release process.

The release process for the v1.18.0 started yesterday so you can be sure that, if we merge this PR, spacer will be part of the new release bundle.

@geriux
Copy link
Contributor Author

geriux commented Nov 26, 2019

Hey @geriux, not sure if I am missing some context but usually the practice is that we update bundle files through the release process.

The release process for the v1.18.0 started yesterday so you can be sure that, if we merge this PR, spacer will be part of the new release bundle.

Yup, I updated the bundles so reviewers were able to test the Spacer block in the main apps before merging. It also was a good test as part of my onboarding to know how to generate bundles, etc =)

@maxme maxme changed the base branch from develop to release/1.18.0 November 26, 2019 13:10
@maxme
Copy link
Contributor

maxme commented Nov 26, 2019

I'm not sure if there is a process for this, but I'll drop the bundle changes from the PR and keep the gutenberg ref change only.

@maxme
Copy link
Contributor

maxme commented Nov 26, 2019

@geriux the e2e tests seem to fail - can you check it's related to your changes?

@pinarol
Copy link
Contributor

pinarol commented Nov 26, 2019

I'll drop the bundle changes from the PR and keep the gutenberg ref change only

Sounds good 👍bundles are usually generated only on release branches, this one was needed just for testing purposes because we needed to verify Spacer block appearing in the block picker while metro is off.

@geriux
Copy link
Contributor Author

geriux commented Nov 26, 2019

@geriux the e2e tests seem to fail - can you check it's related to your changes?

It shouldn't be but I'll check, thanks!

@geriux geriux force-pushed the feature/enable-spacer-block branch from eb940e3 to d813bb4 Compare November 26, 2019 15:38
@maxme maxme merged commit 83e1190 into release/1.18.0 Nov 26, 2019
@maxme maxme deleted the feature/enable-spacer-block branch November 26, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants