-
Notifications
You must be signed in to change notification settings - Fork 57
Enable Spacer block in production #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SergioEstevao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on iOS! ![]()
|
Hey @geriux, not sure if I am missing some context but usually the practice is that we update bundle files through the release process. The release process for the v |
Yup, I updated the bundles so reviewers were able to test the |
|
I'm not sure if there is a process for this, but I'll drop the bundle changes from the PR and keep the gutenberg ref change only. |
|
@geriux the e2e tests seem to fail - can you check it's related to your changes? |
Sounds good 👍bundles are usually generated only on release branches, this one was needed just for testing purposes because we needed to verify Spacer block appearing in the block picker while metro is off. |
It shouldn't be but I'll check, thanks! |
eb940e3 to
d813bb4
Compare
This enables the
Spacerblock in productionFixes #1587
GutenbergPR -> WordPress/gutenberg#18605To test:
WordPress iOS-> wordpress-mobile/WordPress-iOS#12970WordPress Android-> wordpress-mobile/WordPress-Android#10817Update release notes:
RELEASE-NOTES.txt.