Skip to content

Conversation

@jd-alexander
Copy link
Contributor

gutenberg: WordPress/gutenberg#27401
gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2854
WPiOS PR: wordpress-mobile/WordPress-iOS#15420
FluxCAndroid wordpress-mobile/WordPress-FluxC-Android#1823

This PR's content was already reviewed here

To test:
To verify the behavior you can utilize the instructions in the PR above.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 18, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jd-alexander
Copy link
Contributor Author

@develric I will remove the [Status] Not Ready for Merge label once the gutenberg-mobile and gutenberg PRs have been reviewed.

@jd-alexander jd-alexander added this to the 16.6 milestone Jan 18, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 18, 2021

You can test the changes on this Pull Request by downloading the APK here.

Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jd-alexander 👋 , checked this as per #13612 instructions and can confirm the behavior is ok (confirm also the system picker notes from that PR, but it's a known thing 👍 ).

I'm approving it; feel free to move it ahead as soon as other dependencies are delivered 🙇 (and of course it goes without say, just ping me if anything needed from my side, happy to make another check round in case dependencies change 👍 ).

@jd-alexander jd-alexander changed the base branch from develop to gutenberg/after_1.45.0 January 21, 2021 20:07
@jd-alexander
Copy link
Contributor Author

jd-alexander commented Jan 21, 2021

I updated the base branch on this PR to gutenberg/after_1.45.0 since the release is in process.

@jd-alexander jd-alexander modified the milestones: 16.6, 16.7 Jan 21, 2021
@jd-alexander jd-alexander changed the base branch from gutenberg/after_1.45.0 to develop January 26, 2021 05:37
@jd-alexander jd-alexander marked this pull request as ready for review January 26, 2021 06:43
mzorz added a commit that referenced this pull request Jan 27, 2021
@jd-alexander jd-alexander merged commit 970ac1c into develop Jan 28, 2021
@jd-alexander jd-alexander deleted the gutenberg/audio_block_consolidated_media_picker_integration branch January 28, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants