-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Gutenberg] Audio block - Consolidated & Normal Media Picker Integration #13808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg] Audio block - Consolidated & Normal Media Picker Integration #13808
Conversation
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
@develric I will remove the |
|
You can test the changes on this Pull Request by downloading the APK here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jd-alexander 👋 , checked this as per #13612 instructions and can confirm the behavior is ok (confirm also the system picker notes from that PR, but it's a known thing 👍 ).
I'm approving it; feel free to move it ahead as soon as other dependencies are delivered 🙇 (and of course it goes without say, just ping me if anything needed from my side, happy to make another check round in case dependencies change 👍 ).
|
I updated the base branch on this PR to |
…backs being worked on in #13808
gutenberg: WordPress/gutenberg#27401gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#2854WPiOSPR: wordpress-mobile/WordPress-iOS#15420FluxCAndroidwordpress-mobile/WordPress-FluxC-Android#1823This PR's content was already reviewed here
To test:
To verify the behavior you can utilize the instructions in the PR above.
PR submission checklist:
RELEASE-NOTES.txtif necessary.