Contact info api - featureConfig implementation #13804

mzorz · 2021-01-18T14:46:27Z

This PR builds on top of #13758 and implements the FeatureConfig class.

Related Gutenberg-mobile: PR wordpress-mobile/gutenberg-mobile#3015 and wordpress-mobile/gutenberg-mobile#3001
Related Gutenberg PR: WordPress/gutenberg#28293

To test:

CASE A: flag ON for production

build vanilla with this PR as is
on a jetpack site with version 8.5 and above, create a GB Post
verify the block picker in mobile gutenberg shows the Contact Info block and you can insert and use it in the Post.
switch the site to a self hosted site, or a site using a jetpack version older than 8.5
verify the block picker in mobile gutenberg does NOT show the Contact Info block

CASE B: flag OFF for production

in WordPress/build.gradle edit this line in the vanilla flavor buildConfigField "boolean", "CONTACT_INFO_BLOCK_AVAILABLE", "true" and set it ti false instead
build vanilla
on a jetpack site with version 8.5 and above, create a GB Post
verify the block picker in mobile gutenberg does NOT show the Contact Info block

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…vailability

peril-wordpress-mobile · 2021-01-18T14:46:32Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2021-01-18T16:15:06Z

You can test the changes on this Pull Request by downloading the APK here.

JavonDavis · 2021-01-25T18:55:29Z

Hey! Bumping this to 16.7, if you'd like to get it in for this release please merge this into release/16.6 and then DM me to release a new Beta version.

jd-alexander · 2021-01-26T19:57:17Z

WordPress/src/main/java/org/wordpress/android/util/SiteUtils.java

    public static final String AZTEC_EDITOR_NAME = "aztec";
    public static final String WP_STORIES_CREATOR_NAME = "wp_stories_creator";
    public static final String WP_STORIES_JETPACK_VERSION = "9.1";
+    public static final String WP_CONTACT_INFO_JETPACK_VERSION = "8.5";


Hi @illusaen or @mzorz I have a question about the Jetpack version. I am looking at the release notes above and it specifies that the contact info block works on WP.com site and sites with JetPack 9.1 and above. But this value is 8.5 so I am just checking if this is expected i.e I am checking to see if these versions should be the same or not. Thanks 🙇

Good observation @jd-alexander ! My findings tell me the first version of Jetpack shipping with that block was 8.5, so the release notes should be updated accordingly 👍 @illusaen do you want to update it?

Also another question @mzorz should the block be tested with vanilla debug or vanilla release ?

I think both should work as long as it's vanilla - I tested vanillaDebug only but it should be the same (the productFlavors work this way)

jd-alexander

1.When the build config value in the vanilla block was set to true with the Jetpack version at 9.3.1 the Contact Info Block was shown in the inserter.

 2. When the build config value in the vanilla block was set to false with Jetpack version 9.3.1 the Contact Info Block was NOT shown.
 
   3. When the build config value was true and the Jetpack version was rolled back to 8.4.2 (below 8.5) the Contact Info block was NOT shown.
   
   LGTM 🚢 I didn't approve this because the gb-mobile PR needs updating and the WPiOS PR needs to be reviewed. Once those are reviewed/updated this PR can be approved and merged in.

…backs being worked on in #13808

mzorz · 2021-01-27T21:43:50Z

Thanks so much for your review @jd-alexander !! 🙇

mzorz · 2021-01-27T21:49:08Z

NOTE! Not to be merged before #13808 gets merged as we've added empty body implementations of the new callback interfaces introduced there (see 5a408ed) cc @jd-alexander

illusaen · 2021-01-28T00:23:36Z

See wordpress-mobile/gutenberg-mobile#3064 for issue coming up with contact info block.

jd-alexander · 2021-02-05T22:56:21Z

@mzorz @illusaen is this still being shipped into 16.7? Since the Gutenberg counterparts have been merged in, and the contact block is enabled I suppose that is the case, so let me know if this is due another review. Thank you.

illusaen · 2021-02-06T08:29:12Z

@jd-alexander I don't think it'll make it in -- got a bug to fix in contact info in general first. It's actually not enabled in production yet still so no huge hurry :)

mzorz · 2021-02-06T12:27:27Z

is this still being shipped into 16.7?

Bumped the milestone 👍 thanks for the heads up @jd-alexander

…ing split out for now

mzorz · 2021-02-09T10:09:22Z

Set the Contact Info block available to non-production builds only in a31c71a as per the reasons explained in this comment by @illusaen

Consequently, also removed the relevant information from RELEASE-NOTES.md in 28f4a20 (see iOS counterpart in wordpress-mobile/WordPress-iOS@6cbd1a1)

…enberg work

mzorz · 2021-02-09T22:17:54Z

@jd-alexander this is finally ready for another look 😅 - the gutenberg-mobile PR is merged so I updated the reference here. Also worth noting, this is not going into production for now, relevant changes were made as explained in this #13804 (comment). 🙏

jd-alexander · 2021-02-10T01:57:15Z

@jd-alexander this is finally ready for another look 😅 - the gutenberg-mobile PR is merged so I updated the reference here. Also worth noting, this is not going into production for now, relevant changes were made as explained in this #13804 (comment). 🙏

Understood. Thanks for the ping @mzorz I will take a look soon 👌🏾

jd-alexander

The code here looks good. I am going to give this another run tomorrow and then we are good to merge.

mzorz · 2021-02-22T22:01:07Z

@illusaen moving this to draft as per conversation with @JavonDavis , let me know when there's a need to resurface this and we can catch up 👍

mzorz · 2021-04-08T12:20:34Z

This should be ready @illusaen:

tried alphaDebug: Contact Info is present in the block picker and I can add it and use it in a Post ✅
tried vanillaDebug: Contact Info block is not present in the block picker ✅

Also worth noting: we need to change the valuein gutenberg-mobile here from __DEV__ to true once we're fine with getting the Contact Info block no longer behind a feature flag

const supportedJetpackBlocks = {
	'contact-info': {
		available: __DEV__,
	},
	story: {
		available: true,
	},
};

Another thing to note: given the check on WPiOS counterpart here I believe given the flag is behind this check return BuildConfiguration.current ~= [.localDeveloper, .a8cBranchTest], it shouldn’t have the release notes yet, should it? (see the relevant similar Android commit and message here #13804 (comment))

Let me know 👍

illusaen · 2021-04-08T17:04:59Z

This should be ready @illusaen:

1. tried `alphaDebug`: Contact Info **is** present in the block picker and I can add it and use it in a Post ✅

2. tried `vanillaDebug`: Contact Info block is **not** present in the block picker ✅

Awesome thanks!!

Also worth noting: we need to change the valuein gutenberg-mobile here from __DEV__ to true once we're fine with getting the Contact Info block no longer behind a feature flag
Yep! That'll be happening after this and the Jetpack PR are merged.

It shouldn’t have the release notes yet, should it?
Nope no release notes should be on there :) I'll be adding them in the DEV flag switch PR after these are merged.

Wendy Chen and others added 5 commits January 13, 2021 06:16

WC: Adding in contact info capability.

8eab0aa

WC: Updating release notes for contact info.

8e84102

Merge branch 'develop' into contact-info-api-mario

160a92d

added ContactIngoBlockFeatureConfig to control GB ContactInfo block a…

16c855c

…vailability

reverted unwanted changes to .idea/compiler.xml

81bcacb

mzorz added Gutenberg Editing and display of Gutenberg blocks. gutenberg-mobile labels Jan 18, 2021

mzorz added this to the 16.6 milestone Jan 18, 2021

mzorz requested a review from illusaen January 18, 2021 14:46

mzorz changed the title ~~Contact info api mario~~ Contact info api - featureConfig implementation Jan 18, 2021

This was referenced Jan 18, 2021

Contact info api jetpack / update Gutenberg submodule wordpress-mobile/gutenberg-mobile#3015

Merged

[RNMobile] Added contactInfoBlock enabling capabilities flag to mobile gutenberg bridge WordPress/gutenberg#28293

Merged

JavonDavis modified the milestones: 16.6, 16.7 Jan 25, 2021

jd-alexander self-requested a review January 26, 2021 03:48

jd-alexander reviewed Jan 26, 2021

View reviewed changes

jd-alexander reviewed Jan 27, 2021

View reviewed changes

mzorz added 3 commits January 27, 2021 13:44

updated gutenberg-mobile hash

563182e

updated gutenberg-mobile branch

5a15271

fixed merge conflicts - WARNING added mock implemetations of new call…

5a408ed

…backs being worked on in #13808

illusaen mentioned this pull request Jan 27, 2021

Contact Info - Adding Feature Flag + Jetpack API Version Check wordpress-mobile/gutenberg-mobile#3001

Merged

2 tasks

illusaen mentioned this pull request Jan 27, 2021

Contact Info Enabled in Production #13758

Closed

3 tasks

jd-alexander added 2 commits January 27, 2021 20:08

Updated gb mobile ref.

1f66092

gb mobile ref updated with bundles.

544708e

Merge branch 'develop' into contact-info-api-mario

c95f9b1

mzorz modified the milestones: 16.7, 16.8 Feb 6, 2021

mzorz added 3 commits February 9, 2021 06:57

updated gutenberg-mobile

8d94051

Removing release notes from this branch as user facing changes are be…

28f4a20

…ing split out for now

disabled Contact Info block for production (vanilla flavors)

a31c71a

updated gutenberg-mobile hash with latest develop, already merged gut…

e32af3f

…enberg work

jd-alexander added the [Status] Not Ready for Merge label Feb 12, 2021

jd-alexander reviewed Feb 12, 2021

View reviewed changes

mzorz modified the milestones: 16.8, 16.9 Feb 22, 2021

mzorz marked this pull request as draft February 22, 2021 22:01

mzorz removed this from the 16.9 milestone Feb 22, 2021

updated branch fixed with base branch

977f5f9

mzorz marked this pull request as ready for review April 8, 2021 12:15

mzorz added this to the 17.2 milestone Apr 8, 2021

mzorz removed the [Status] Not Ready for Merge label Apr 8, 2021

illusaen approved these changes Apr 8, 2021

View reviewed changes

illusaen merged commit 70ce7de into develop Apr 8, 2021

illusaen deleted the contact-info-api-mario branch April 8, 2021 17:05

enejb mentioned this pull request May 17, 2021

Layout Grid Availability - featureConfig implementation #14667

Merged

Contact info api - featureConfig implementation #13804

Contact info api - featureConfig implementation #13804

Uh oh!

Conversation

mzorz commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

peril-wordpress-mobile bot commented Jan 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JavonDavis commented Jan 25, 2021

Uh oh!

jd-alexander Jan 26, 2021

Choose a reason for hiding this comment

Uh oh!

mzorz Jan 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jd-alexander Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

mzorz Jan 27, 2021

Choose a reason for hiding this comment

Uh oh!

jd-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

mzorz commented Jan 27, 2021

Uh oh!

mzorz commented Jan 27, 2021

Uh oh!

illusaen commented Jan 28, 2021

Uh oh!

jd-alexander commented Feb 5, 2021

Uh oh!

illusaen commented Feb 6, 2021

Uh oh!

mzorz commented Feb 6, 2021

Uh oh!

mzorz commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mzorz commented Feb 9, 2021

Uh oh!

jd-alexander commented Feb 10, 2021

Uh oh!

jd-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

mzorz commented Feb 22, 2021

Uh oh!

mzorz commented Apr 8, 2021

Uh oh!

illusaen commented Apr 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mzorz commented Jan 18, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Jan 18, 2021 •

edited

Loading

peril-wordpress-mobile bot commented Jan 18, 2021 •

edited

Loading

mzorz Jan 27, 2021 •

edited

Loading

mzorz commented Feb 9, 2021 •

edited

Loading