Skip to content

Conversation

@develric
Copy link
Contributor

@develric develric commented Feb 16, 2021

Fixes #13456

This PR adds unit testing for 13456 issue introduced components.

To test

  • Check the unit tests pass
  • I needed to add RoleUtilsWrapper.kt and SimpleDateFormatWrapper.kt to make it testable. Would be good to make some smoke testing just in case 😄

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@develric develric added this to the 16.8 milestone Feb 16, 2021
@develric develric requested a review from khaykov February 16, 2021 00:38
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 16, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 16, 2021

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 16, 2021

You can test the changes on this Pull Request by downloading the APK here.

@khaykov khaykov self-assigned this Feb 18, 2021
Base automatically changed from issue/13456-p2-people-invite-links-analytics to develop February 18, 2021 23:02
Copy link
Contributor

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding test, @develric ! Looks good, and I smoked test the functionality to make sure it works.

@khaykov khaykov merged commit ac4d51c into develop Feb 19, 2021
@khaykov khaykov deleted the issue/13456-p2-people-invite-links-unit-test branch February 19, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for invite links to P2 sites

4 participants